Skip to content

remove inner snippet - #10854

Merged
mairaw merged 4 commits into
dotnet:masterfrom
mairaw:inner-samples3
Mar 4, 2019
Merged

mairaw merged 4 commits into
dotnet:masterfrom
mairaw:inner-samples3

Conversation

@mairaw

@mairaw mairaw commented Mar 1, 2019 •

Copy link
Copy Markdown
Contributor

Contributes to #1255

Dependent on dotnet/samples#687

Needs to check if before and after are the same

@mairaw mairaw added migration-fixes 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) labels Mar 1, 2019
@mairaw mairaw added this to the March 2019 milestone Mar 1, 2019
@mairaw mairaw self-assigned this Mar 1, 2019
@mairaw
mairaw requested a review from BillWagner as a code owner March 1, 2019 21:54
@rpetrusha

Copy link
Copy Markdown
Contributor

Closing and reopening to begin new build.

@rpetrusha rpetrusha closed this Mar 2, 2019
@rpetrusha rpetrusha reopened this Mar 2, 2019

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. They are the same. You can merge when you're ready.

@mairaw

mairaw commented Mar 4, 2019

Copy link
Copy Markdown
Contributor Author

I just noticed that Ron had removed the snippet number on purpose. I'll see if the snippet comments will go away with this change. Otherwise, I'll remove the comments from the samples in dotnet/samples because I don't want those comments showing up.

@mairaw mairaw closed this Mar 4, 2019
@mairaw mairaw reopened this Mar 4, 2019
@mairaw
mairaw merged commit 43d10e5 into dotnet:master Mar 4, 2019
@mairaw
mairaw deleted the inner-samples3 branch March 4, 2019 06:57
@mairaw mairaw removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants