Skip to content

Remove codesnippet folders - #10856

Merged
mairaw merged 3 commits into
dotnet:masterfrom
mairaw:remove-snippets
Mar 4, 2019
Merged

mairaw merged 3 commits into
dotnet:masterfrom
mairaw:remove-snippets

Conversation

@mairaw

@mairaw mairaw commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

Fixes #1255

Dependent on #10854

This should be the end of that issue 🎆

@mairaw mairaw added migration-fixes 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) labels Mar 1, 2019
@mairaw mairaw self-assigned this Mar 1, 2019
@mairaw
mairaw requested a review from BillWagner as a code owner March 1, 2019 22:00
@rpetrusha

Copy link
Copy Markdown
Contributor

Closing and reopening to begin new build.

@rpetrusha rpetrusha closed this Mar 2, 2019
@rpetrusha rpetrusha reopened this Mar 2, 2019

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except there's one broken link that doesn't appear to have a corresponding code snippet. It's just a simple 5-line example, so it can easily be inline. I'll open a PR to create it inline.

@mairaw mairaw closed this Mar 4, 2019
@mairaw mairaw reopened this Mar 4, 2019
@mairaw mairaw mentioned this pull request Mar 4, 2019
@mairaw mairaw removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Mar 4, 2019
@mairaw mairaw added this to the March 2019 milestone Mar 4, 2019
@mairaw
mairaw merged commit 7c2c4c2 into dotnet:master Mar 4, 2019
@mairaw
mairaw deleted the remove-snippets branch March 4, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants