Skip to content

add missing snippet - #687

Merged
rpetrusha merged 3 commits into
dotnet:masterfrom
mairaw:missing-snippet
Mar 2, 2019
Merged

rpetrusha merged 3 commits into
dotnet:masterfrom
mairaw:missing-snippet

Conversation

@mairaw

@mairaw mairaw commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

Contributes to dotnet/docs#1255

@mairaw mairaw added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Mar 1, 2019
@mairaw mairaw self-assigned this Mar 1, 2019
@mairaw
mairaw requested a review from BillWagner as a code owner March 1, 2019 21:51

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. I've condensed the code somewhat by removing unnecessary using statements and fully-qualified type and member references. I'll merge for you and rebuild the PR in docs so that we can finally be rid of these snippets.

@rpetrusha
rpetrusha merged commit de48ec8 into dotnet:master Mar 2, 2019
@mairaw
mairaw deleted the missing-snippet branch March 4, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants