Repository navigation
Expand relative paths for CLI arguments - #9892
Conversation
53ff121 to
3e51ef3
Compare
5e25845 to
6a79edc
Compare
|
I like it. My concern is we don't have a good way to prevent people forgetting to use full path in the future. But it should be an improvement anyway. Put that in master is appropriate. I am not confident there is no unexpected bug since we have existing mixed path, so it could get more testing. @dotnet/cli-contrib what do you think? |
|
I still left it |
peterhuene
left a comment
There was a problem hiding this comment.
Generally on board with these changes (really great to see this fixed, as it is definitely confusing to have paths relative to project files). My only question is whether or not we can leverage recent BCL methods for some of this implementation. With that answered, I can sign off.
|
@dasMulli, thanks for being such an outstanding community member and for providing this work; it is something I think definitely needs to be fixed. 3.0 (master) would be a great place to land this since it is a breaking change, one which we will need to document, but I think greatly improves the command line UX. |
dddd470 to
83e49a5
Compare
|
test Debian8.2 x64 Debug Build |
83e49a5 to
f349395
Compare
f349395 to
03d788f
Compare
|
test Ubuntu x64 Release Build |
|
Moving out of WIP since it appears to work fine. |
|
@peterhuene could you take another look? |
|
I'm finished reviewing, mostly nits regarding naming of things. This looks great! With the remaining nits dealt with, I think we're ready to merge this. Ping @livarcocc regarding this PR since it is a breaking change (a good one, imo). Should we document this behavior for 3.0 release notes somewhere? Perhaps a "breaking change" label for us to filter by? |
|
adding @leecow and @KathleenDollard for the breaking change documentation. |
6749e1e to
abaf197
Compare
|
@peterhuene thanks, addressed naming issues. #NamingIsHard |
abaf197 to
10da5a0
Compare
|
@livarcocc any objections to merging this into 3.0? |
|
Definitely add a "breaking change" label. |
|
I have marked the bugs and the PR with a breaking change label. I will merge the PR in a couple minutes. |
|
@dasMulli thank you very much for the contribution, |
|
Can you please put this in the "what's new" documentation of .NET Core 3.0? This subtle change actually has a side effect on build servers that build both .NET Core 2.x and .NET Core 3.0 projects with the same build scripts. Although we accept that this is a breaking change (and we will separate the build steps between .NET Core 2 and 3 projects now that we know it), but it just not announced in the release notes (at least in what we could find here: https://docs.microsoft.com/en-us/dotnet/core/whats-new/dotnet-core-3-0) |
|
cc @mairaw @KathleenDollard for docs/visibility |
|
Which version did this go out in and what commands does it effect? At this point, is ti a matter for release docs or as a note in relevant docs? Ideas for text welcome. |
|
I think this went out in .NET Core 3.0 Preview 1 and affects the build, clean, pack, publish, restore, store and test commands. Ad wording, maybe something like?: |
|
@dasMulli is correct, pretty sure this was P1. I have nothing else to add to the text because I think that sums it up well. |
|
What is the expected behavior when a solution is built with this change? Will it append the project name to the path? |
|
@dasMulli @mairaw @KathleenDollard Will this still be added to the release notes? In our case, this breaks our CI/CD chain so I think it should be visible in the notes. |
Continuation of #7166 which was too late for 2.0
This changes the output directory for CLI commands to be expanded to a full path based on the current working directory.
This may be a breaking change for some users.
Fixes #6700, #4765