Repository navigation
Conversation
…d outside the project directory.
|
I am supportive of this change. We have gotten a lot of feedback about the current behavior being wrong. I think we should take the break. |
|
I am supportive of this change as well. I just wonder if this is enough or if we should do this in other places as well. Like, in all outputs or maybe all the places where we can specify paths. |
|
I changed the base to master, release/2.0.0 is stabilizing |
|
I just wonder if a change like this should even be made for a minor version increment (2.1). It is breaking, but it really is generally agreed to be a bug. |
|
@dasMulli we cannot decide if this can go to 2.1 yet, since this is a breaking change. This change will need to hold off for a while. Also we also need to make sure this behavior, not relevant to current directory, is the same across the board. |
|
@livarcocc @wli3 can we close this against a single issue (and close the other ones as duplicate)? this one would need an overhaul anyway to check for any new possibly project relative paths. |
|
@dasMulli agree, closing :) |
... when invoked outside the project directory.
This changes the output directory for
packandpublishto be expanded to a full path based on the current working directory. (This is probably most useful when invoking thepackcommand on a solution to generate multiple nupkg files into a single output directory).The original behaviour was introduced with the move to MSBuild since it treats relative paths as relative to the project being built.
Pros of taking it:
Cons of taking it:
cc @piotrpMSFT @livarcocc @eerhardt @nguerrera (don't really know who to tag)
Fixes #6700, #4765