Skip to content

Artifacts for 3.0 GA release - #3429

Merged
leecow merged 1 commit into
masterfrom
30GA
Sep 23, 2019
Merged

leecow merged 1 commit into
masterfrom
30GA

Conversation

@vivmishra

Copy link
Copy Markdown
Contributor

No description provided.

@leecow
leecow merged commit df90a67 into master Sep 23, 2019
@dasMulli

Copy link
Copy Markdown

I know that my making breaking changes to the CLI in 3.0 isn't very good to admit publicly, but any reason dotnet/cli#9892 didn't make it into the contributors list? 😅

@vivmishra
vivmishra deleted the 30GA branch September 23, 2019 17:48
@jamshedd

Copy link
Copy Markdown
Member

@vivmish, @leecow, can you please take a look?

@leecow

leecow commented Sep 24, 2019

Copy link
Copy Markdown
Member

@dasMulli - my cleaning script to remove MSFT folks is pretty aggressive so will have a look and get you added back to the list.

@dasMulli

Copy link
Copy Markdown

no stress, it's not an issue for me or anything, was just surprised.

@leecow

leecow commented Sep 24, 2019

Copy link
Copy Markdown
Member

Figured it out ... my starting commit sha wasn't far enough back. #3460

@nxtn nxtn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider clarifying the commits range in the contributor list. The ranges are specified as dates in other lists (except for 1.0.0).

I'm very happy that I'm considered a "member" rather than a "contributor" :)

@nxtn

nxtn commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

/cc @vivmishra @leecow

@leecow

leecow commented Oct 8, 2019

Copy link
Copy Markdown
Member

Thanks, @NextTurn. Will look at dates again to see if I can resolve the issues they were previously giving me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants