Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 18 files
You're on the cubic free plan with 8 free PR reviews remaining this month. Upgrade for unlimited reviews.
Re-trigger cubic
…table A snapshot alone omitted an exit timestamp, retained only one terminal, and could not count missed terminals. The per-module bounded history reports every retained exit with its chosen disposition; eviction increments dropped so a returning observer knows it has only a suffix. daemon_started_at_ms marks the in-memory daemon incarnation, distinguishing a quiet daemon from a restarted one with no retained history.
ualtinok
force-pushed
the
ci/pr23-terminals
branch
from
August 16, 2026 13:24
542fee0 to
d0f9e6b
Compare
Contributor
Author
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork PRs skip the Rust matrix; twin for iceteaSA's #23 at 542fee0.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by cubic
Add bounded per‑module terminal-exit history and expose it via a new
supervisor.terminalsRPC andck module terminals. Previously only the most recent exit was visible viasupervisor.list; nowsupervisor.listalso includeslast_exit_ms, and the full recent history is queryable on demand, including a dropped count and the daemon start time.subc-control0.2.0): addssupervisor.terminalsrequest/response,TerminalHistory/TerminalEntry/TerminalDispositiontypes, and alast_exit_msfield onSupervisorEntry; catalogs include the new op.subc-core0.4.0): new per-moduleTerminalRingtracks exits and chosen dispositions; integrated into all terminal paths (clean stops, drains, crashes, restarts).ck module terminals <id>command with--json; help text updated; golden fixtures added for the new API.subc-control0.2.0 (e.g.,subc-client-rsnow requires it) and adjust any exhaustive matches overClientControlRequest/ClientControlResponseto handlesupervisor.terminals.supervisor.list, tolerate the newlast_exit_msfield; if you enumerate supported ops, acceptsupervisor.terminals.Written for commit 542fee0. Summary will update on new commits.