Conversation
…table A snapshot alone omitted an exit timestamp, retained only one terminal, and could not count missed terminals. The per-module bounded history reports every retained exit with its chosen disposition; eviction increments dropped so a returning observer knows it has only a suffix. daemon_started_at_ms marks the in-memory daemon incarnation, distinguishing a quiet daemon from a restarted one with no retained history.
Contributor
Author
|
Closing: conflicted twins get no merge ref, so Actions creates no run at all — retrigger by rebase, not by re-push. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 18 files
You're on the cubic free plan with 5 free PR reviews remaining this month. Upgrade for unlimited reviews.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh twin for iceteaSA's #23 at d0f9e6b (+retrigger empty commit): PR #25 stopped receiving CI runs on synchronize/reopened events.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by cubic
Adds bounded per-module terminal history and a new way to read it, so operators can see child exits and dispositions even when the supervisor command channel is closed. Also exposes the most recent exit timestamp in supervisor listings.
supervisor.terminals: returnsTerminalHistorywithdaemon_started_at_ms, orderedentries(each withexit_code,exit_signal,at_ms,disposition), anddroppedcount; served off the supervisor command channel to remain available during supervisor failure.ck module terminals <id>shows the retained exits; help text updated.TerminalRing(default capacity 32) records exits at drain/stop/crash with Unix ms timestamps and selected disposition;SupervisorEntrynow includes optionallast_exit_ms.subc-control->0.2.0,subc-core->0.4.0;crates/subc-client-rsdepends onsubc-control0.2.supervisor.terminals; updated op catalogs and supervisor entries; tests document thatfake-aft-stubmust be built viacargo test -p subc-core.Migration
supervisor.listshould handle optionallast_exit_ms.supervisor.terminalsmust depend onsubc-control0.2and passmodule_id.Written for commit 15fba64. Summary will update on new commits.