Conversation
…re a restart Retain the attested principal and bind Instant on every RouteBinding so the census can distinguish reserved consumers from direct connections and report route age.\n\nDraining bindings stay visible with their draining state. supervisor.routes remains control-plane-only and is not exposed through the MCP facade or any agent-tool surface.
This was referenced Aug 16, 2026
Closed
There was a problem hiding this comment.
1 issue found across 14 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="crates/subc-core/src/control.rs">
<violation number="1" location="crates/subc-core/src/control.rs:67">
P2: This advertises `supervisor.routes` to every module even though modules cannot invoke it. A module that follows the `HELLO_ACK.subc_ops` allowlist can attempt the operation and receive `unsupported_control_frame`; keep this client-only operation in client discovery while excluding it from the module capability list.</violation>
</file>
You're on the cubic free plan with 6 free PR reviews remaining this month. Upgrade for unlimited reviews.
Re-trigger cubic
| ops::SUPERVISOR_HEALTH_PROBE, | ||
| ops::SUPERVISOR_HEALTH, | ||
| ops::SUPERVISOR_STDERR_TAIL, | ||
| ops::SUPERVISOR_ROUTES, |
There was a problem hiding this comment.
P2: This advertises supervisor.routes to every module even though modules cannot invoke it. A module that follows the HELLO_ACK.subc_ops allowlist can attempt the operation and receive unsupported_control_frame; keep this client-only operation in client discovery while excluding it from the module capability list.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At crates/subc-core/src/control.rs, line 67:
<comment>This advertises `supervisor.routes` to every module even though modules cannot invoke it. A module that follows the `HELLO_ACK.subc_ops` allowlist can attempt the operation and receive `unsupported_control_frame`; keep this client-only operation in client discovery while excluding it from the module capability list.</comment>
<file context>
@@ -64,6 +64,7 @@ const SUBC_CONTROL_OPS: &[&str] = &[
ops::SUPERVISOR_HEALTH_PROBE,
ops::SUPERVISOR_HEALTH,
ops::SUPERVISOR_STDERR_TAIL,
+ ops::SUPERVISOR_ROUTES,
];
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork PRs skip the Rust matrix; twin for iceteaSA's #26 at 8a4d21c.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by cubic
Adds a control‑plane census
supervisor.routesto enumerate live route consumers per module, including during drains. Previously routes were not observable; now the daemon reports consumer identity, route age, and draining state without querying modules.subc-control(0.1.2): addsops::SUPERVISOR_ROUTES,ClientControlRequest::SupervisorRoutes, andClientControlResponse::SupervisorRoutes. Consumers are reported asreserved { module_id }ordirect { connection_id }, withage_msanddraining.principalandbound_atinRouteBinding; introducesendpoint_routesandroute_censusthat snapshot under a single read lock and preserve draining status.subc-core(0.3.2): wireshandle_supervisor_routesto the forwarding census; updates bench harness to usePrincipal::Direct; expands thin-core op catalog.ck routes [<module-id>]with table or--jsonoutput.Written for commit 8a4d21c. Summary will update on new commits.