Repository navigation
test(e2e): pin high-risk podcast journeys in Obsidian - #384
Merged
Merged
Conversation
Deploying podnotes with
|
| Latest commit: |
501663c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ec1fa5fa.podnotes.pages.dev |
| Branch Preview URL: | https://test-journey-e2e.podnotes.pages.dev |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| await library.restoreJourneyWorkspace(suiteClient); | ||
| if (!wasEnabled) { | ||
| await suiteClient.dev.evalJsonAsync( | ||
| `(async () => { await app.plugins.disablePluginAndSave(${JSON.stringify(PLUGIN_ID)}); await app.plugins.saveConfig(); return true; })()`, |
|
|
||
| function byCss(name: string, selector: string, text?: string): UiTarget { | ||
| const filter = | ||
| text === undefined ? "" : `.filter((el) => el.textContent.trim() === ${q(text)})`; |
| playerTab: byCss("Player tab", `${PLAYER_VIEW} button[aria-label="Player"]`), | ||
| podcastCard: (title: string): UiTarget => ({ | ||
| name: `podcast card ${title}`, | ||
| elements: `[...document.querySelectorAll(${q(`${PLAYER_VIEW} .podcast-grid button`)})].filter((button) => (button.getAttribute("aria-label") ?? button.querySelector("img")?.alt ?? button.textContent.trim()) === ${q(title)})`, |
| ), | ||
| episode: (title: string): UiTarget => ({ | ||
| name: `episode ${title}`, | ||
| elements: `[...document.querySelectorAll(${q(`${PLAYER_VIEW} .podcast-episode-item`)})].filter((el) => !el.closest(".episode-player") && el.querySelector(".episode-item-title")?.textContent.trim() === ${q(title)})`, |
| ), | ||
| menuItem: (title: string): UiTarget => ({ | ||
| name: `menu item ${title}`, | ||
| elements: `[...document.querySelectorAll(".menu .menu-item")].filter((el) => el.querySelector(".menu-item-title")?.textContent.trim() === ${q(title)})`, |
| byCss(`settings tab ${name}`, ".modal.mod-settings .vertical-tab-nav-item", name), | ||
| settingControl: (settingName: string, control: string): UiTarget => ({ | ||
| name: `${control} of setting ${settingName}`, | ||
| elements: `[...document.querySelectorAll(".modal.mod-settings .setting-item")].filter((row) => row.querySelector(".setting-item-name")?.textContent.trim() === ${q(settingName)}).map((row) => row.querySelector(${q(control)})).filter(Boolean)`, |
| byCss(`settings tab ${name}`, ".modal.mod-settings .vertical-tab-nav-item", name), | ||
| settingControl: (settingName: string, control: string): UiTarget => ({ | ||
| name: `${control} of setting ${settingName}`, | ||
| elements: `[...document.querySelectorAll(".modal.mod-settings .setting-item")].filter((row) => row.querySelector(".setting-item-name")?.textContent.trim() === ${q(settingName)}).map((row) => row.querySelector(${q(control)})).filter(Boolean)`, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 18 real-Obsidian tests that cover all 15 highest-risk R5 journeys before the v3 rewrite. They exercise feed import, real playback, restart, Resume and timestamp links, local audio, offline downloads, transcription, sync conflicts, and mobile startup.
Five tests accept only the reproduced bug signatures in #357, #358, #375, #377, and #378. Other failures stay hard failures. A fixed bug makes its test request removal of the marker.
The harness restores cache, data, workspace files, recent-file history, mobile mode, and enabled plugins while it holds the vault lock. A temporary test plugin captures errors before PodNotes initializes. Runtime checks also cover the 21 baseline E2E tests.
Verification
npm run test:e2epassed three consecutive full runs, each with 39 tests. Complete command wall times are 91.64, 88.49, and 92.09 seconds.npm run lint,npm run format:check,npm run typecheck,npm run build,npm run test, andnpm run docs:buildpassed. The unit/component suite passed 1,263 tests in 81 files.http://127.0.0.1.nip.io:<port>. iTunes and OpenAI responses are stubbed only at the network boundary with a fake transcription secret. Source mutations proved one defect per new test file, plus startup-error detection. Workspace rollback passed after the save delay and another ordinary save.Journey table and full QA report. Proof logs, mutations, probes, and independent reviews.
Mobile uses desktop emulation. The macOS restart branch has static review only. Earlier mutation experiments and the fixture screenshot are identified as historical evidence in the report.
Follow-ups
#380 tracks recorder recovery after interruption. #382 tracks late runtime errors cleared by final suite restoration. #383 tracks future Notice wording changes. Error-report cascades, macOS relaunch logging, shared-runner relaunch reuse, lifecycle imports, and Vitest stack hook ordering remain follow-ups. The sparse fixture drops an item without both title and description because it violates RSS 2.0.
Release impact
None. The change touches only
tests/e2e. No product, dependency, schema, API, URI, or CI change.Refs #357, #358, #375, #377, #378, #380, #382, #383.
Note
Add end-to-end journey test suite covering PodNotes feeds, playback, links, and resilience
expectKnownFailure, which fails when the expected assertion passes or the observed failure does not match the recorded reproductionMacroscope summarized 501663c.