[Alir3z4]

Add Webhooks module to support https://developer.bigcommerce.com/api/stores/v2/webhooks

[Alir3z4]

Would be great to know when this will be into master or at least can someone review this code and let me know if there's any further development required on it?

[tgsergeant]

Tentative 👍 from me. My only suggestion is to squash down the commits before they go into master.

As for getting this merged, maybe @maetl can help?

[maetl]

@tgsergeant not me, as I no longer have merge access to any of these public repos.

[Alir3z4]

You mean the repo doesn't have a maintainer at the moment ?

[hockeybuggy]

So no maintainer?

[hockeybuggy]

There is a bit of a quirk in this PR. A DeleteableApiResource has the delete_all method but the Big Commerce API does not have a corresponding endpoint:

DELETE https://api.bigcommerce.com/stores/(store_id)/v2/hooks
(Results in a 404)

This PR is still quite usable.

[Alir3z4]

@hockeybuggy I use this patch in my application and I haven't tried delete all on the resource but for sure I can delete webhook objects:

https://developer.bigcommerce.com/api/stores/v2/webhooks#delete-hook

[hpk]

+1 on this. Would love to see this merged.

[gabelimon]

Since webhooks doesn't allow delete_all we'll need to re-work this a bit. The solutions that come to mind are

1. Adding a SingleDeleteableResource (I'm open to names) which DeleteableResource inherits from and which the webhooks resource uses instead of DeleteableResource
2. Having the webhooks resource throw an exception if delete_all is called

I'll give this some thought but please chime in if you guys feel strongly one way or the other or if you have a less ugly solution.

[hockeybuggy]

I implemented the second option proposed by @gabelimon here -> Alir3z4/pull/1

[gabelimon]

Also, would you mind removing the extra line?

[hockeybuggy]

I could but, I think it would be a style violation. When I remove it and run pep8 against the file:

➤ pep8 bigcommerce/resources/webhooks.py
bigcommerce/resources/webhooks.py:3:1: E302 expected 2 blank lines, found 1

[gabelimon]

Cool, then leave it.

[hockeybuggy]

@gabelimon So this is ok to merge into master after @Alir3z4 gets a chance to merge Alir3z4#1 ?

[gabelimon]

Yeah we're good to go if he merges your change.

[Alir3z4]

@gabelimon @hockeybuggy I merged the pull request ;)

[gabelimon]

👍
We're good to go. Next time please squash your commits though.