Skip to content

Add webhooks resource #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabelimon merged 5 commits into from
Jan 28, 2015
Merged

Add webhooks resource #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd7e202
Add Webhooks resource module
Alir3z4 Jul 19, 2014
dc5e356
Import webhooks module into resources module
Alir3z4 Jul 19, 2014
058d9a5
Fix typo in resource name
Alir3z4 Aug 17, 2014
6e4e2e0
Overrode the delete_all method on Webhooks.
hockeybuggy Jan 27, 2015
04dd611
Merge pull request #1 from hockeybuggy/webhook-raise-not-implemented-…
Alir3z4 Jan 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bigcommerce/resources/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@
from .shipping import *
from .store import *
from .tax_classes import *
from .time import *
from .time import *
from .webhooks import *
10 changes: 10 additions & 0 deletions bigcommerce/resources/webhooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from .base import *


@gabelimon gabelimon Jan 27, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, would you mind removing the extra line?

@hockeybuggy hockeybuggy Jan 27, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could but, I think it would be a style violation. When I remove it and run pep8 against the file:

➤ pep8 bigcommerce/resources/webhooks.py
bigcommerce/resources/webhooks.py:3:1: E302 expected 2 blank lines, found 1

@gabelimon gabelimon Jan 27, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, then leave it.

class Webhooks(ListableApiResource, CreateableApiResource,
UpdateableApiResource, DeleteableApiResource):
resource_name = 'hooks'

@classmethod
def delete_all(self, connection=None):
raise NotImplementedError("The webhook resource does not have delete_all endpoint")
9 changes: 8 additions & 1 deletion tests/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import unittest
from bigcommerce.resources import Mapping, Orders, ApiResource, OrderShipments
from bigcommerce.resources.orders import OrderCoupons
from bigcommerce.resources.webhooks import Webhooks
from mock import MagicMock


Expand Down Expand Up @@ -167,4 +168,10 @@ def test_delete(self):
shipment = OrderShipments({'id': 1, 'order_id': 2, '_connection': connection})
self.assertEqual(shipment.delete(), {})

connection.make_request.assert_called_once_with('DELETE', 'orders/2/shipments/1', None, {}, {})
connection.make_request.assert_called_once_with('DELETE', 'orders/2/shipments/1', None, {}, {})

def test_webhook_delete_all(self):
connection = MagicMock()
connection.make_request.return_value = {}

self.assertRaises(NotImplementedError, Webhooks.delete_all, connection=connection)