Skip to content

This exception is unused and inherits from Exception rather than HttpException - #21

Closed
hockeybuggy wants to merge 1 commit into
bigcommerce:masterfrom
hockeybuggy:remove-unused-exception
Closed

hockeybuggy wants to merge 1 commit into
bigcommerce:masterfrom
hockeybuggy:remove-unused-exception

Conversation

@hockeybuggy

Copy link
Copy Markdown
Contributor

From the root of the repo:

➤ grep NotLoggedInException . -R -n
./bigcommerce/exception.py:41:class NotLoggedInException(Exception): pass

Is there a usecase for it that I am missing?

@hockeybuggy
hockeybuggy force-pushed the remove-unused-exception branch from 690dd60 to 8f83c0b Compare January 28, 2015 19:06
@gabelimon

Copy link
Copy Markdown
Contributor

This whole file seems pretty littered to me. I'm not going to remove this for now since in theory someone could be using this exception even though they shouldn't be.

@hockeybuggy

Copy link
Copy Markdown
Contributor Author

You're right it's possible that someone is depending on NotLoggedInException, but their are not gaining anything from it; It's functionally identical to Exception.

Maybe this removal could be included in a 0.11.0 release? Speaking of which maybe minor version should be rolled now that #15 has been merged.

@gabelimon

Copy link
Copy Markdown
Contributor

I agree. I'm going to close this but I'm going to open an issue so that this isn't lost and forgotten.

Thanks for bringing the minor version thing up, I'm still working on getting access to the package so I'll update that when I can.

@gabelimon gabelimon mentioned this pull request Feb 2, 2015
@gabelimon gabelimon closed this Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants