Repository navigation
This exception is unused and inherits from Exception rather than HttpException - #21
Closed
hockeybuggy wants to merge 1 commit into
Closed
hockeybuggy wants to merge 1 commit into
hockeybuggy wants to merge 1 commit into
Conversation
hockeybuggy
force-pushed
the
remove-unused-exception
branch
from
January 28, 2015 19:06
690dd60 to
8f83c0b
Compare
Contributor
|
This whole file seems pretty littered to me. I'm not going to remove this for now since in theory someone could be using this exception even though they shouldn't be. |
Contributor
Author
|
You're right it's possible that someone is depending on Maybe this removal could be included in a |
Contributor
|
I agree. I'm going to close this but I'm going to open an issue so that this isn't lost and forgotten. Thanks for bringing the minor version thing up, I'm still working on getting access to the package so I'll update that when I can. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the root of the repo:
Is there a usecase for it that I am missing?