refactor: move Base adapters out of generic lifecycle - #25
Merged
Merged
Conversation
This was referenced Aug 1, 2026
codeforester
marked this pull request as ready for review
August 1, 2026 01:08
codeforester
added a commit
to basefoundry/base
that referenced
this pull request
Aug 1, 2026
## Summary Closes #1837. Paired with [base-cli PR 25](basefoundry/base-cli#25) and [base-cli issue 22](basefoundry/base-cli#22). - adds Base-owned discovery, configuration, runtime, and history adapters; - updates Base profile and consumers to use those adapters; - keeps base-cli as the consumer-neutral lifecycle and callback layer; - preserves Base behavior with the existing Base test suite. The Pylint and Tests workflows are temporarily pinned to the base-cli PR 25 commit until the dependency PR merges. ## Validation - `PYTHONPATH=/Users/rameshhp/work/base-cli-worktrees/22-move-base-adapters/lib/python:/Users/rameshhp/work/base-worktrees/22-base-adapter-boundary/cli/python /Users/rameshhp/work/base-cli-worktrees/22-move-base-adapters/.venv/bin/python -m pytest -q` - Result: 931 passed, 1 skipped, 248 subtests passed.
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #22.
A paired Base consumer PR moves the implementation into Base-owned adapters and pins this commit until this PR merges.
Validation
uv run --extra dev pytest -q./tests/validate.shgit diff --checkBase consumer validation is in the paired Base PR.