docs(ui): complete four stale capability lists in ui/README.md - #325
Merged
Merged
Conversation
Four subsections enumerate a capability and were never extended when a later feature landed, so each states a count/list the code no longer matches: - inline-confirm coverage list omitted model deletion (app.js calls confirmInline(deleteModel...)); - timeCell was said to have two call sites; there are three (the raise request list's created_at is the third); - the data-label table list omitted the admin model table (model-body), contradicting the same file's keyboard-nav section; - the mkDetailHtml content list omitted peak-hour pricing (if (m.peak)), while the sibling conditional multi was listed. Documentation only; no code or gate changes.
Owner
Author
|
Self-review (committer, Verified against the tree this branch is based on (
Documentation-only change; no gate added, consistent with the repo's |
9 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui/README.mdhas four subsections that enumerate a capability (a coverage list, a call-site count, a table roster, a renderer's content list). Each was written when it was true and was never extended when a later feature landed, so it now states a list or count the code no longer matches. This PR corrects the four values to what the code implements. Documentation only — no code, no gate.Related Issue
None (self-found during a documentation audit; no tracking issue exists).
Changes
ui/README.md, one per stale subsection:已覆盖) omitted model deletion —ui/js/app.jscallsconfirmInline(..., deleteModel(…))alongside key/sharing/department deletion. Added模型删除.timeCellcall-site count said "two call sites" (transactions / API Key) — there are three: the raise-request list'screated_at(ui/js/app.js,admin.raiserow) is the third. Corrected to交易/API Key/加额申请三个调用点.data-labeltable roster omitted the admin model table (#model-body), while the same file's keyboard-navigation section already listsmodel-body— a self-contradiction. Added模型.mkDetailHtmlcontent list omitted peak-hour pricing — the renderer appends it conditionally (if (m.peak),ui/js/app.js:863), exactly like the sibling conditionalm.multiwhich is listed. Added高峰时段价(仅 m.peak 显示…).Tests
cargo test— 426 passed; 0 failedcargo fmt --check— clean (rc 0)cargo clippy --all-targets -- -D warnings— clean (rc 0)ui/README.mdis prose, and the repo's settled convention for this class (doc-comment-claimsaxis) is to fix the value, not to add a gate. Precedents: docs(perf_gate): drop the stale file count from the gate header #309/docs(ui): stop restating the i18n counters and correct two stale gate claims #310/docs(ui): describe the recent-models store the code actually keeps #313/docs(ui): describe the login page the two-column redesign left behind #314/docs(ui): name only the bump sites, test and hint the code still has #315/docs(ui): stop claiming a .bar-label alias the stylesheet no longer has #317/docs(ui): name the operator card the way the code names it #319/fix(i18n): drop the retired "shown once" claim from the generate-key toast #320/docs(ui): name the translator helper the code actually declares #322/docs(ui): state the inlineForm validate contract the code implements #324.Checklist
docs/<description>)docs(ui): …)