docs(ui): stop claiming a .bar-label alias the stylesheet no longer has - #317
Merged
Merged
Conversation
The comment above `.bar-row .bar-top` read "(线上 .bar-label 为其别名)" — i.e. it asserted that writing `class="bar-label"` today still renders. It does not. `git grep -n 'bar-label'` over the whole tree returns exactly one hit: that comment. There is no `.bar-label` rule, no markup emits it, and `docs/prototype/aitokenpool-console.html` does not carry it either — so the three possible consumers (rule / implementation / prototype) are all absent. `git show 75dcb2c` (#154, the shared component layer) is where the name was removed: the same commit deletes `.bar-row .bar-label` and adds `.bar-row .bar-top`, and its message reads "bar-label/bar -> bar-top/bar-track/bar-fill". The alias claim was written by that very commit, so it has been false since it was authored. #154 left two such breadcrumbs. #316 fixed the `.stat` one; this is the other. The wording mirrors the phrasing #316 landed for `.stat-card` — name the historical name and say there is no alias rule, rather than inventing one (the rejected alternative in both cases: adding a real `.bar-label` rule). Also bumps `ui/index.html`'s `style.css?v=` token, as every style.css change in this file's history does. No behavioural change: one comment plus a cache-bust token.
Owner
Author
|
Self-review (committer; Claim checked against the tree at
Related commit / scope: same commit as #316 ( Verified: Merging. |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The comment above
.bar-row .bar-topinui/css/style.cssclaimed that thelive stylesheet also answers to
.bar-label:/* .bar-row .bar-top:原型「名称左 / 数值右」的行头(线上 .bar-label 为其别名) */That is false.
git grep -n 'bar-label'over the whole tree returns exactlyone hit — that comment. There is no
.bar-labelrule, no markup emits theclass, and the design baseline
docs/prototype/aitokenpool-console.htmldoesnot carry it either. All three possible consumers (stylesheet rule /
implementation / prototype) are absent, so writing
class="bar-label"todaymatches nothing at all.
The alias claim is not stale drift in the usual sense:
git show 75dcb2c(#154, the shared component layer) is the commit that removed the name —
it deletes
.bar-row .bar-labeland adds.bar-row .bar-top, and its messagereads
bar-label/bar -> bar-top/bar-track/bar-fill. The sentence asserting analias was written by the same commit that dropped the thing it points at.
#154 left two such breadcrumbs. #316 fixed the
.statone(
.stat-card); this is the second. The wording here mirrors the phrasing#316 landed — name the historical name and say there is no alias rule, instead
of inventing one. (Adding a real
.bar-labelrule was the rejected alternativein both cases: the code emits
.bar-top, and nothing else consumes.bar-label.)Related Issue
None.
Changes
ui/css/style.css: the.bar-row .bar-topcomment now names.bar-labelas the historical name feat(ui): add shared component layer (stat-card/pill/tag/toolbar/bar-list) + define missing button variants (rant 2026-09-11, PR3) #154 replaced and states there is noalias rule.
ui/index.html:css/style.css?v=20260924-2→?v=20260924-3(this file's history bumps the token with every style.css change).
Tests
cargo test— 413 passed; 0 failedcargo fmt --check— cleancargo clippy --all-targets -- -D warnings— cleanno behaviour to assert.
Checklist
docs/)