docs(ui): describe the login page the two-column redesign left behind - #314
Merged
Merged
Conversation
The v1.20 "brand & login atmosphere" section of ui/README.md still described three decorations that #153 (e33bf2e) deleted when the login page went from a single centered card to the two-column split: - .login-view::before (44px grid + radial mask) - .login-view::after (accent glow) + the login-float keyframes - the .logo accent ring and .logo::after inner highlight None of those four selectors exists anywhere outside ui/README.md any more (git grep over ui/index.html, ui/css/style.css and ui/js/ returns nothing), so the file was the only carrier left. The v1.19 login-page section had the same problem in one bullet: .login-card .logo (52px glow) and .login-brand h1 (22px) are gone as well -- the logo is .logo-tile now and the headline is h1.lb-headline. Rewrite both in place, naming the redesign that invalidated them (the idiom the file already uses for the endpoint-card section) and stating what exists today. The favicon bullet and the focus-ring claim were still true and are kept. Docs only: no production code, no i18n key, no cache-bust token. cargo test 413/0, fmt/clippy clean.
Owner
Author
|
✅ Self-review (Committer; Docs-only change,
Merging. |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui/README.mdstill documented the login page the way it looked before the two-column redesign.Two sections are affected, for the same reason:
e33bf2e(#153, "redesign login page as two-column layout + rework sidebar", 2026-09-11) replaced the single centered card, deleted the CSS those lines describe, and the README was never updated.## 品牌与登录页氛围约定(v1.20 … G)— three of its bullets named selectors that no longer exist:.login-view::before(44px grid + radial mask).login-view::after(accent glow) + thelogin-floatkeyframes.logoaccent ring and the.logo::afterinner highlight## 登录页约定(v1.19 … G)— its "visual polish" bullet named.login-card .logo(52px glow) and.login-brand h1(22px), both gone as well.This file was the only carrier left.
git grep -nE "login-float|login-view::before|login-view::after|logo::after" -- ui/index.html ui/css/style.css ui/js/returns nothing, andrgba(78,205,196survives in exactly three places — all of them in this README.What changed
Both sections are corrected in place, naming the redesign that invalidated them (the idiom this file already uses — see the endpoint-card section's "(v1.22 全站 UI 重设计对齐原型…)") and stating what the login page actually is today:
.login-brand(.eyebrow/h1.lb-headline/.lb-points/.gw) alongside the frosted.login-themetoggle, with the logo rendered by.logo-tile.Claims that are still true are kept: the favicon bullet (inline SVG data URI, verified in
ui/index.html), the focus ring.login-form .input:focus, and the globalprefers-reduced-motionrule.Tests
cargo test— 413 passed, 0 failedcargo fmt --check— cleancargo clippy --all-targets -- -D warnings— cleanDocs only: no production code, no i18n key, no cache-bust token touched.
Deliberately not in this PR
The "记住我" bullet of
## 登录页约定also names ademo-hintelement that no longer exists inui/index.html. That one was removed by a different change —35291b3(v0.6.0, demo-seed removal), not the redesign — so it gets its own PR instead of being mixed in here.