Skip to content

[chore](paimon) remove paimon-cpp dependency - #67385

Merged
hello-stephen merged 1 commit into
apache:masterfrom
suxiaogang223:codex/remove-paimon-cpp-master
Sep 3, 2026
Merged

[chore](paimon) remove paimon-cpp dependency#67385
hello-stephen merged 1 commit into
apache:masterfrom
suxiaogang223:codex/remove-paimon-cpp-master

Conversation

@suxiaogang223

@suxiaogang223 suxiaogang223 commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: N/A

Related PR: #67378, #67432

Remove paimon-cpp completely from the thirdparty manifest, BE reader, build integration, tests, and Arrow patch set. Also fold the Arrow cleanup from #67432 into the standard thirdparty workflow, removing the temporary fingerprint, recovery, and lifecycle scripts.

Deprecated Thrift enum/field values and IGNORE_PAIMON_CPP remain only for compatibility. This master change is the source used to publish the shared master/branch-4.1 thirdparty package.

Release note

Remove the deprecated paimon-cpp reader and build dependency. Paimon reads continue through JNI and native readers.

Check List (For Author)

  • Test:
    • Paimon FE connector: 553 passed, 1 live test skipped
    • Clean Arrow 24 patch application and package build
    • Thirdparty scripts, build hygiene, shell syntax, workflow YAML, and diff checks
  • Behavior changed:
    • Yes. paimon-cpp is removed; deprecated wire values remain for compatibility.
  • Does this need documentation:
    • No

@hello-stephen

hello-stephen commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223 suxiaogang223 mentioned this pull request Sep 1, 2026
Merged
5 tasks
@suxiaogang223
suxiaogang223 marked this pull request as ready for review September 2, 2026 02:03
@suxiaogang223
suxiaogang223 force-pushed the codex/remove-paimon-cpp-master branch from 2182c4a to 6624286 Compare September 2, 2026 02:26
@suxiaogang223
suxiaogang223 marked this pull request as draft September 2, 2026 02:27
@suxiaogang223
suxiaogang223 marked this pull request as ready for review September 2, 2026 02:38
@suxiaogang223

suxiaogang223 commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

hello-stephen commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 63.02% (29546/46887)
Line Coverage 48.05% (309753/644629)
Region Coverage 43.64% (250206/573361)
Branch Coverage 45.23% (116484/257527)

suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Sep 2, 2026
@suxiaogang223
[chore](paimon) remove paimon-cpp dependency
7e3596d 
### What problem does this PR solve?

Issue Number: N/A

Related PR: apache#67385, apache#67432

Problem Summary:

Remove the deprecated paimon-cpp source, build, reader, configuration, and test dependencies while retaining deprecated Thrift wire values for rolling-upgrade compatibility. Keep branch-4.1 aligned with master by using the standard thirdparty manifest and removing the temporary Arrow fingerprint, recovery, lifecycle, and Paimon-specific patch files. The shared thirdparty package continues to be produced from master.

### Release note

Remove the deprecated paimon-cpp reader and build dependency.

### Check List (For Author)

- Test: Unit Test and manual test
  - Paimon FE unit tests
  - Clean Arrow 24 patch application and idempotent download flow
  - Thirdparty script tests, shell syntax, workflow YAML, and diff checks
- Behavior changed: Yes. Paimon logical splits use JNI; deprecated wire values remain for compatibility.
- Does this need documentation: No
@suxiaogang223
suxiaogang223 force-pushed the codex/remove-paimon-cpp-master branch from 6624286 to 5d08a80 Compare September 2, 2026 07:36
@suxiaogang223

suxiaogang223 commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

hello-stephen commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.71% (2053/2642)
Line Coverage 65.68% (37491/57080)
Region Coverage 52.98% (34995/66057)
Branch Coverage 56.35% (11238/19942)

@suxiaogang223
[chore](paimon) Remove paimon-cpp dependency
2a32705 
### What problem does this PR solve?

Issue Number: N/A

Related PR: apache#67378, apache#67432

Problem Summary:

Remove the deprecated paimon-cpp package, reader implementation, build integration, tests, and Paimon-specific Arrow patch. Retain deprecated wire and configuration values for compatibility. Fold Arrow source variables back into the standard thirdparty manifest and remove the temporary fingerprint, recovery, and lifecycle scripts so the next master automation package is the final cleaned artifact.

### Release note

Remove the deprecated paimon-cpp reader and build dependency. Paimon reads continue through the JNI and native readers.

### Check List (For Author)

- Test: Unit Test and manual test
  - Paimon FE connector reactor: 553 tests passed, 1 live test skipped
  - Clean Arrow 24 patch application and Arrow package build
  - Thirdparty script tests, build hygiene, shell syntax, workflow YAML, and diff checks
- Behavior changed: Yes. The paimon-cpp reader and enable_paimon_cpp_reader session variable are removed; deprecated wire values remain for compatibility.
- Does this need documentation: No
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Sep 2, 2026
@suxiaogang223
[chore](paimon) remove paimon-cpp dependency
77d29b7 
### What problem does this PR solve?

Issue Number: N/A

Related PR: apache#67385, apache#67432

Problem Summary:

Remove the deprecated paimon-cpp source, build, reader, configuration, and test dependencies while retaining deprecated Thrift wire values for rolling-upgrade compatibility. Keep branch-4.1 aligned with master by using the standard thirdparty manifest and removing the temporary Arrow fingerprint, recovery, lifecycle, and Paimon-specific patch files. The shared thirdparty package continues to be produced from master.

### Release note

Remove the deprecated paimon-cpp reader and build dependency.

### Check List (For Author)

- Test: Unit Test and manual test
  - Paimon FE unit tests
  - Clean Arrow 24 patch application and idempotent download flow
  - Thirdparty script tests, shell syntax, workflow YAML, and diff checks
- Behavior changed: Yes. Paimon logical splits use JNI; deprecated wire values remain for compatibility.
- Does this need documentation: No
@suxiaogang223
suxiaogang223 force-pushed the codex/remove-paimon-cpp-master branch from 5d08a80 to 2a32705 Compare September 2, 2026 09:31
@suxiaogang223

suxiaogang223 commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

hello-stephen commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.71% (2053/2642)
Line Coverage 65.64% (37468/57080)
Region Coverage 52.87% (34923/66057)
Branch Coverage 56.32% (11231/19942)

@hello-stephen

hello-stephen commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 63.02% (29548/46890)
Line Coverage 48.06% (309816/644704)
Region Coverage 43.67% (250456/573551)
Branch Coverage 45.23% (116481/257551)

@hello-stephen

hello-stephen commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.12% (34573/45417)
Line Coverage 61.21% (390097/637345)
Region Coverage 57.32% (327532/571368)
Branch Coverage 58.18% (149413/256812)

@hello-stephen

hello-stephen commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/21) 🎉
Increment coverage report
Complete coverage report

yiguolei pushed a commit that referenced this pull request Sep 2, 2026
@suxiaogang223
branch-4.1: [chore](paimon) remove paimon-cpp dependency (#67378)
57636ca 
### What problem does this PR solve?

Issue Number: N/A

Related PR: #67385, #67432

Remove paimon-cpp completely from branch-4.1 while retaining deprecated
Thrift wire values for rolling-upgrade compatibility. Keep its
thirdparty sources, Arrow patches, and standard scripts aligned with
master; branch-4.1 does not publish a separate thirdparty package and
consumes the package produced from master.

### Release note

Remove the deprecated paimon-cpp reader and build dependency.

### Check List (For Author)

- Test:
    - [x] Paimon FE unit tests
    - [x] Clean Arrow 24 patch application and idempotent download flow
- [x] Thirdparty scripts, shell syntax, workflow YAML, and diff checks
- Behavior changed:
- [x] Yes. Paimon logical splits use JNI; deprecated wire values remain
for compatibility.
- Does this need documentation:
    - [x] No
morrySnow
morrySnow reviewed Sep 2, 2026
View reviewed changes
Comment thread fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
@suxiaogang223

suxiaogang223 commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

skip buildall

@hello-stephen
hello-stephen merged commit 7829cb7 into apache:master Sep 3, 2026
46 of 49 checks passed
@suxiaogang223
suxiaogang223 deleted the codex/remove-paimon-cpp-master branch September 3, 2026 06:08
@suxiaogang223 suxiaogang223 mentioned this pull request Sep 3, 2026
Merged
4 tasks
suxiaogang223 added a commit that referenced this pull request Sep 4, 2026
@suxiaogang223
[fix](paimon) tolerate removed paimon-cpp session variable (#67472)
4eb013c 
### What problem does this PR solve?

Issue Number: N/A

Related PR: #67385

After removing `enable_paimon_cpp_reader`, older clients and replayed
state may still reference it. Add the name to
`REMOVED_SESSION_VAR_NAMES` so existing compatibility handling silently
ignores SET and tolerates reads instead of reporting an unknown system
variable.

### Release note

None

### Check List (For Author)

- Test:
- [x] No local test needed; this is a one-entry compatibility allowlist
update.
    - [x] `git diff --check`
- Behavior changed:
    - [x] Yes. References to the removed variable are tolerated.
- Does this need documentation:
    - [x] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@924060929 924060929 924060929 approved these changes
@yiguolei yiguolei yiguolei approved these changes
@CalvinKirs CalvinKirs CalvinKirs approved these changes
@Gabriel39 Gabriel39 Gabriel39 approved these changes
@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@suxiaogang223 @hello-stephen @924060929 @yiguolei @CalvinKirs @Gabriel39 @morrySnow