Skip to content

branch-4.1: [chore](paimon) remove paimon-cpp dependency - #67378

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
suxiaogang223:codex/remove-paimon-cpp-phase1
Sep 2, 2026
Merged

branch-4.1: [chore](paimon) remove paimon-cpp dependency#67378
yiguolei merged 1 commit into
apache:branch-4.1from
suxiaogang223:codex/remove-paimon-cpp-phase1

Conversation

@suxiaogang223

@suxiaogang223 suxiaogang223 commented Sep 1, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: N/A

Related PR: #67385, #67432

Remove paimon-cpp completely from branch-4.1 while retaining deprecated Thrift wire values for rolling-upgrade compatibility. Keep its thirdparty sources, Arrow patches, and standard scripts aligned with master; branch-4.1 does not publish a separate thirdparty package and consumes the package produced from master.

Release note

Remove the deprecated paimon-cpp reader and build dependency.

Check List (For Author)

  • Test:
    • Paimon FE unit tests
    • Clean Arrow 24 patch application and idempotent download flow
    • Thirdparty scripts, shell syntax, workflow YAML, and diff checks
  • Behavior changed:
    • Yes. Paimon logical splits use JNI; deprecated wire values remain for compatibility.
  • Does this need documentation:
    • No

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223

Copy link
Copy Markdown
Member Author

run buildall

@suxiaogang223 suxiaogang223 changed the title [chore](paimon) remove paimon-cpp dependency [branch-4.1][chore](paimon) remove paimon-cpp dependency Sep 1, 2026
@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.58% (25801/43307)
Line Coverage 44.18% (264914/599586)
Region Coverage 40.08% (210043/524094)
Branch Coverage 41.55% (96967/233356)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.32% (31317/42138)
Line Coverage 58.52% (348119/594841)
Region Coverage 55.22% (290107/525329)
Branch Coverage 56.06% (130685/233114)

@suxiaogang223 suxiaogang223 changed the title [branch-4.1][chore](paimon) remove paimon-cpp dependency branch-4.1: [chore](paimon) remove paimon-cpp dependency Sep 2, 2026
@suxiaogang223
suxiaogang223 marked this pull request as ready for review September 2, 2026 02:02
@suxiaogang223
suxiaogang223 force-pushed the codex/remove-paimon-cpp-phase1 branch from 79747a2 to 5478d34 Compare September 2, 2026 02:18
@suxiaogang223

Copy link
Copy Markdown
Member Author

run buildall

suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Sep 2, 2026
### What problem does this PR solve?

Issue Number: N/A

Related PR: apache#67378

Problem Summary:

Doris still downloads, builds, links, and carries the deprecated paimon-cpp reader even though master plans serialized Paimon splits for the JNI reader. Remove the paimon-cpp thirdparty package, BE reader implementation, obsolete session-variable plumbing, and related tests. Keep the deprecated PaloInternalService field, TPaimonReaderType.PAIMON_CPP enum value, and IGNORE_PAIMON_CPP option for rolling-upgrade and configuration compatibility. Preserve Arrow as an independent shared thirdparty component so existing prebuilts remain usable and future automation artifacts no longer include paimon-cpp.

### Release note

Remove the deprecated paimon-cpp reader and its build dependency. Paimon reads continue through the JNI and native readers.

### Check List (For Author)

- Test: Unit Test and manual test
  - mvn -f fe/pom.xml -pl :fe-connector-paimon -am install -Dmaven.build.cache.enabled=false (553 tests passed, 1 live test skipped)
  - thirdparty Arrow and ADBC lifecycle tests
  - thirdparty download/mirror/checksum/retry script tests
  - build-support/check-build-hygiene.sh
  - shell syntax, YAML parsing, and git diff --check
- Behavior changed: Yes. The paimon-cpp reader and enable_paimon_cpp_reader session variable are removed; deprecated wire fields remain for compatibility.
- Does this need documentation: No
@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.34% (1942/2479)
Line Coverage 64.91% (34550/53231)
Region Coverage 52.39% (33115/63212)
Branch Coverage 55.03% (10174/18488)

@suxiaogang223
suxiaogang223 force-pushed the codex/remove-paimon-cpp-phase1 branch from 5478d34 to 7e3596d Compare September 2, 2026 07:36
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Sep 2, 2026
### What problem does this PR solve?

Issue Number: N/A

Related PR: apache#67378, apache#67432

Problem Summary:

Remove the deprecated paimon-cpp package, reader implementation, build integration, tests, and Paimon-specific Arrow patch. Retain deprecated wire and configuration values for compatibility. Fold Arrow source variables back into the standard thirdparty manifest and remove the temporary fingerprint, recovery, and lifecycle scripts so the next master automation package is the final cleaned artifact.

### Release note

Remove the deprecated paimon-cpp reader and build dependency. Paimon reads continue through the JNI and native readers.

### Check List (For Author)

- Test: Unit Test and manual test
  - Paimon FE connector reactor: 553 tests passed, 1 live test skipped
  - Clean Arrow 24 patch application and Arrow package build
  - Thirdparty script tests, build hygiene, shell syntax, workflow YAML, and diff checks
- Behavior changed: Yes. The paimon-cpp reader and enable_paimon_cpp_reader session variable are removed; deprecated wire values remain for compatibility.
- Does this need documentation: No
@suxiaogang223

Copy link
Copy Markdown
Member Author

run buildall

### What problem does this PR solve?

Issue Number: N/A

Related PR: apache#67385, apache#67432

Problem Summary:

Remove the deprecated paimon-cpp source, build, reader, configuration, and test dependencies while retaining deprecated Thrift wire values for rolling-upgrade compatibility. Keep branch-4.1 aligned with master by using the standard thirdparty manifest and removing the temporary Arrow fingerprint, recovery, lifecycle, and Paimon-specific patch files. The shared thirdparty package continues to be produced from master.

### Release note

Remove the deprecated paimon-cpp reader and build dependency.

### Check List (For Author)

- Test: Unit Test and manual test
  - Paimon FE unit tests
  - Clean Arrow 24 patch application and idempotent download flow
  - Thirdparty script tests, shell syntax, workflow YAML, and diff checks
- Behavior changed: Yes. Paimon logical splits use JNI; deprecated wire values remain for compatibility.
- Does this need documentation: No
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Sep 2, 2026
### What problem does this PR solve?

Issue Number: N/A

Related PR: apache#67378, apache#67432

Problem Summary:

Remove the deprecated paimon-cpp package, reader implementation, build integration, tests, and Paimon-specific Arrow patch. Retain deprecated wire and configuration values for compatibility. Fold Arrow source variables back into the standard thirdparty manifest and remove the temporary fingerprint, recovery, and lifecycle scripts so the next master automation package is the final cleaned artifact.

### Release note

Remove the deprecated paimon-cpp reader and build dependency. Paimon reads continue through the JNI and native readers.

### Check List (For Author)

- Test: Unit Test and manual test
  - Paimon FE connector reactor: 553 tests passed, 1 live test skipped
  - Clean Arrow 24 patch application and Arrow package build
  - Thirdparty script tests, build hygiene, shell syntax, workflow YAML, and diff checks
- Behavior changed: Yes. The paimon-cpp reader and enable_paimon_cpp_reader session variable are removed; deprecated wire values remain for compatibility.
- Does this need documentation: No
@suxiaogang223
suxiaogang223 force-pushed the codex/remove-paimon-cpp-phase1 branch from 7e3596d to 77d29b7 Compare September 2, 2026 09:31
@suxiaogang223

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.34% (1942/2479)
Line Coverage 64.89% (34539/53231)
Region Coverage 52.27% (33044/63212)
Branch Coverage 55.00% (10168/18488)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.40% (31352/42138)
Line Coverage 58.56% (348334/594841)
Region Coverage 55.27% (290328/525329)
Branch Coverage 56.15% (130883/233114)

@yiguolei
yiguolei merged commit 57636ca into apache:branch-4.1 Sep 2, 2026
25 of 31 checks passed
@suxiaogang223
suxiaogang223 deleted the codex/remove-paimon-cpp-phase1 branch September 3, 2026 02:01
hello-stephen pushed a commit that referenced this pull request Sep 3, 2026
### What problem does this PR solve?

Issue Number: N/A

Related PR: #67378, #67432

Remove paimon-cpp completely from the thirdparty manifest, BE reader,
build integration, tests, and Arrow patch set. Also fold the Arrow
cleanup from #67432 into the standard thirdparty workflow, removing the
temporary fingerprint, recovery, and lifecycle scripts.

Deprecated Thrift enum/field values and `IGNORE_PAIMON_CPP` remain only
for compatibility. This master change is the source used to publish the
shared master/branch-4.1 thirdparty package.

### Release note

Remove the deprecated paimon-cpp reader and build dependency. Paimon
reads continue through JNI and native readers.

### Check List (For Author)

- Test:
    - [x] Paimon FE connector: 553 passed, 1 live test skipped
    - [x] Clean Arrow 24 patch application and package build
- [x] Thirdparty scripts, build hygiene, shell syntax, workflow YAML,
and diff checks
- Behavior changed:
- [x] Yes. paimon-cpp is removed; deprecated wire values remain for
compatibility.
- Does this need documentation:
    - [x] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants