Skip to content

[fix](paimon) tolerate removed paimon-cpp session variable - #67472

Merged
suxiaogang223 merged 1 commit into
apache:masterfrom
suxiaogang223:codex/ignore-removed-paimon-session-var
Sep 4, 2026
Merged

[fix](paimon) tolerate removed paimon-cpp session variable#67472
suxiaogang223 merged 1 commit into
apache:masterfrom
suxiaogang223:codex/ignore-removed-paimon-session-var

Conversation

@suxiaogang223

@suxiaogang223 suxiaogang223 commented Sep 3, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: N/A

Related PR: #67385

After removing enable_paimon_cpp_reader, older clients and replayed state may still reference it. Add the name to REMOVED_SESSION_VAR_NAMES so existing compatibility handling silently ignores SET and tolerates reads instead of reporting an unknown system variable.

Release note

None

Check List (For Author)

  • Test:
    • No local test needed; this is a one-entry compatibility allowlist update.
    • git diff --check
  • Behavior changed:
    • Yes. References to the removed variable are tolerated.
  • Does this need documentation:
    • No

@suxiaogang223
[fix](paimon) tolerate removed paimon-cpp session variable
71fcec7 
### What problem does this PR solve?

Issue Number: N/A

Related PR: apache#67385

Problem Summary:

After removing enable_paimon_cpp_reader, older clients or replayed state that still reference the session variable can receive an unknown-system-variable error. Add the removed name to VariableMgr compatibility handling so SET is ignored and reads return the existing compatibility value.

### Release note

None

### Check List (For Author)

- Test: No local test needed; this is a one-entry compatibility allowlist update. Verified formatting with git diff --check.
- Behavior changed: Yes. References to the removed enable_paimon_cpp_reader variable are tolerated.
- Does this need documentation: No
@hello-stephen

hello-stephen commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223

suxiaogang223 commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

hello-stephen commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/27) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Sep 4, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 16767 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 71fcec75c9039675802a86c5c4cce2ad3975a637, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17717	2983	2958	2958
q2	2091	265	231	231
q3	10220	927	521	521
q4	4670	246	200	200
q5	7690	550	374	374
q6	137	110	92	92
q7	525	498	389	389
q8	9241	867	904	867
q9	3374	2368	2353	2353
q10	6495	835	725	725
q11	390	206	182	182
q12	622	257	195	195
q13	18132	1557	1144	1144
q14	156	150	136	136
q15	q16	433	397	366	366
q17	1418	920	816	816
q18	3043	2276	2265	2265
q19	1260	916	784	784
q20	360	286	199	199
q21	5618	1746	1863	1746
q22	321	264	224	224
Total cold run time: 93913 ms
Total hot run time: 16767 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3299	3229	3245	3229
q2	494	386	369	369
q3	2188	2422	2170	2170
q4	1166	1148	881	881
q5	2153	2114	2087	2087
q6	171	122	86	86
q7	1021	896	855	855
q8	1588	1376	1386	1376
q9	3065	3018	3045	3018
q10	1873	1790	1621	1621
q11	361	264	247	247
q12	442	427	338	338
q13	1492	1521	1172	1172
q14	165	174	153	153
q15	q16	388	387	352	352
q17	3614	3195	3130	3130
q18	4756	4331	4681	4331
q19	867	802	807	802
q20	1138	998	821	821
q21	3711	3030	3211	3030
q22	383	342	326	326
Total cold run time: 34335 ms
Total hot run time: 30394 ms

@hello-stephen

hello-stephen commented Sep 4, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 82146 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 71fcec75c9039675802a86c5c4cce2ad3975a637, data reload: false

query5	4283	412	339	339
query6	398	140	133	133
query7	4914	434	242	242
query8	302	125	129	125
query9	8680	2872	2885	2872
query10	402	224	181	181
query11	5402	1038	925	925
query12	114	69	68	68
query13	1196	433	336	336
query14	6013	2223	2142	2142
query14_1	2007	1984	1985	1984
query15	172	122	111	111
query16	920	372	354	354
query17	798	457	394	394
query18	2342	324	238	238
query19	161	136	114	114
query20	71	69	71	69
query21	196	108	88	88
query22	5583	5399	5306	5306
query23	6673	6323	6029	6029
query23_1	6098	6040	6008	6008
query24	7313	1129	784	784
query24_1	764	800	773	773
query25	437	327	257	257
query26	1237	242	131	131
query27	2760	413	252	252
query28	4666	1496	1537	1496
query29	939	442	358	358
query30	260	157	132	132
query31	814	408	346	346
query32	129	73	81	73
query33	480	234	191	191
query34	978	800	506	506
query35	410	409	355	355
query36	562	582	527	527
query37	119	81	77	77
query38	1015	881	817	817
query39	491	483	462	462
query39_1	472	475	479	475
query40	207	96	81	81
query41	60	57	56	56
query42	77	73	74	73
query43	244	244	215	215
query44	1041	548	559	548
query45	112	109	103	103
query46	792	834	543	543
query47	790	753	702	702
query48	313	309	218	218
query49	544	252	205	205
query50	717	255	197	197
query51	8104	7991	7891	7891
query52	81	65	57	57
query53	197	199	150	150
query54	235	183	175	175
query55	72	62	57	57
query56	276	214	166	166
query57	723	645	654	645
query58	202	177	163	163
query59	1211	1201	1093	1093
query60	230	187	174	174
query61	115	138	114	114
query62	377	215	178	178
query63	174	140	143	140
query64	2750	720	551	551
query65	1644	1646	1627	1627
query66	1937	261	225	225
query67	9741	9660	9690	9660
query68	2753	1230	701	701
query69	327	221	191	191
query70	681	601	622	601
query71	243	165	171	165
query72	2352	1777	1570	1570
query73	626	612	341	341
query74	1563	1236	1132	1132
query75	1170	1091	955	955
query76	2294	743	540	540
query77	245	270	216	216
query78	3820	3603	3205	3205
query79	2998	765	595	595
query80	1574	332	273	273
query81	531	158	132	132
query82	626	125	95	95
query83	282	208	202	202
query84	290	112	91	91
query85	802	386	300	300
query86	483	171	176	171
query87	999	982	900	900
query88	3161	2115	2118	2115
query89	284	194	181	181
query90	2170	128	131	128
query91	132	123	102	102
query92	100	68	71	68
query93	2630	1084	731	731
query94	662	254	213	213
query95	524	254	308	254
query96	791	573	255	255
query97	1081	1059	985	985
query98	178	137	134	134
query99	418	343	310	310
Total cold run time: 179746 ms
Total hot run time: 82146 ms

@hello-stephen

hello-stephen commented Sep 4, 2026

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 14.6 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 71fcec75c9039675802a86c5c4cce2ad3975a637, data reload: false

query1	0.00	0.01	0.00
query2	0.08	0.04	0.03
query3	0.25	0.11	0.11
query4	1.60	0.11	0.10
query5	0.17	0.15	0.16
query6	1.26	0.69	0.68
query7	0.03	0.01	0.00
query8	0.05	0.03	0.03
query9	0.28	0.21	0.21
query10	0.36	0.34	0.35
query11	0.17	0.11	0.12
query12	0.14	0.12	0.12
query13	0.30	0.30	0.31
query14	0.46	0.44	0.47
query15	0.37	0.35	0.37
query16	0.22	0.24	0.23
query17	0.70	0.69	0.67
query18	0.18	0.16	0.17
query19	1.20	1.13	1.19
query20	0.02	0.01	0.01
query21	15.43	0.15	0.12
query22	5.08	0.05	0.04
query23	16.18	0.25	0.10
query24	2.97	0.29	0.25
query25	0.11	0.05	0.03
query26	0.76	0.18	0.12
query27	0.04	0.02	0.03
query28	3.61	0.55	0.27
query29	12.50	3.25	2.59
query30	0.27	0.12	0.12
query31	2.76	0.39	0.16
query32	3.52	0.32	0.23
query33	1.38	1.37	1.38
query34	15.38	2.13	1.77
query35	1.76	1.77	1.72
query36	0.47	0.29	0.29
query37	0.06	0.04	0.04
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.12	0.08	0.07
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 90.46 s
Total hot run time: 14.6 s

@suxiaogang223
suxiaogang223 merged commit 4eb013c into apache:master Sep 4, 2026
33 of 34 checks passed
@suxiaogang223
suxiaogang223 deleted the codex/ignore-removed-paimon-session-var branch September 4, 2026 03:39
@suxiaogang223 suxiaogang223 mentioned this pull request Sep 4, 2026
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@924060929 924060929 924060929 approved these changes
@Gabriel39 Gabriel39 Gabriel39 approved these changes
@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suxiaogang223 @hello-stephen @924060929 @Gabriel39 @morrySnow