Repository navigation
docs(core-client): the pill's page effects live in header-effects since #803 - #838
Merged
Merged
Conversation
…effects #803 moved the pill's page effects into installHeaderEffects (header-effects.js), but the core-client doc still says HeaderPill holds the Message {name} composer label in a layout effect, sets body[data-bt-friend-chat] and sets --bt-remote-empty, and starts actions.filterFaceAtMenu for a face room (#420's note on #820). All four run in that installer now, keyed per Session; header.js keeps only --bt-first-sep. Corrected in place, no behaviour change. Refs #803
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Fixes #837
What changed
docs/subsystems/core-client.mdstill described the page effects as the pill's, and #803 moved them out of it. One file, +3/−3, no behaviour and no source change.HeaderPillholds it in a layout effect" any more —installHeaderEffectsstartsholdComposerLabel(src/client/composer-label.js) for the Session in the main view, keyedsessionId|name, and hands each input the shell's own value back when the Session changes or FlyBot stops (Social UI polish: friend settings shell, approval affordances, face-room copy (aesthetics/usability) #166, The Session header's child seats never render, so the subagent catalog is unreachable #803).body[data-bt-friend-chat],--bt-remote-emptyand the face-room@filter (actions.filterFaceAtMenu) are set by that same installer, not by the pill: corrected the two later mentions as well, so a reader does not findHeaderPillcredited for three effects it no longer runs.header.jskeeps only--bt-first-sep, which the doc already says rides the pill because it needs a turn and always has a header to be drawn in.The one
HeaderPillleft in the file is the test claim on:97(test/header-slot.test.jspins that no such effect runs inHeaderPill), which is still true.Verification at the tip
Tip SHA:
5cbb9fa8Ran:
node .github/scripts/changelog.mjs check→ 14 fragments well formed (no fragment added: nothing user-visible changed).node .github/scripts/testing-layers.mjs --check→ 332 test files in 14 workflows, all classified.Not run (and why):
core/scripts/check-arch-docs.mjs— it diffs againstorigin/mainand this machine has nogitand no.gitin the extracted tree, so it exits withcannot diff against origin/main. The change touches onlydocs/, and the doc it touches is the one arch-docs asks for whencore/src/client/**changes, so it cannot turn that check red.Evidence
The four sentences are checked against the code at
7c1a5fcb:installHeaderEffectsruns the slotscomposer-label,friend-chat,remote-emptyandface-at-menu(core/src/client/header-effects.js), andheader.jsno longer importsholdComposerLabeland only sets--bt-first-sep.