Skip to content

docs(core-client): HeaderPill's page effects live in header-effects since #803 #837

Closed

Description

@Birfy

docs/subsystems/core-client.md still says the pill owns three page effects that #803 moved out of it. HeaderPill no longer runs them: installHeaderEffects (core/src/client/header-effects.js), installed once from apply, owns each one under its own key. The paragraphs in the doc were only partly updated when #803 landed, so a reader is told to look in header.js for code that is in header-effects.js.

The four statements that are now wrong (main 7c1a5fcb)

  • docs/subsystems/core-client.md:99 — "HeaderPill holds the localized Message {name} label … in a layout effect" and, in the same bullet, "In a friend's Bot chat it also sets body[data-bt-friend-chat]". Both are installHeaderEffects keys now: composer-label (header-effects.js:65, holdComposerLabel) and friend-chat (:48).
  • docs/subsystems/core-client.md:108 — "An empty chat with a friend's Bot shows a one-line hint (--bt-remote-empty, set by HeaderPill)". It is set by the remote-empty key in installHeaderEffects (header-effects.js:55-61).
  • docs/subsystems/core-client.md:171 — "HeaderPill (header.js) starts actions.filterFaceAtMenu for a face room". It is the face-at-menu key in installHeaderEffects (header-effects.js:74-76).

What is still true, and must stay: docs/subsystems/core-client.md:98 — "Only --bt-first-sep still rides the pill" — matches header.js:63-65, the only body-level write left in that file. :97 and :98 already name installHeaderEffects correctly.

Acceptance criteria

Refs #803 (moved the effects), #820 (the header seat that replaced the old corner registration).

Activity

  1. added
    documentationImprovements or additions to documentation
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    area:uiWeb/desktop UI and copy
    on Oct 23, 2026
  2. removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:uiWeb/desktop UI and copydocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions