Repository navigation
Keep a same-named friend's Bot off the local look - #1078
Merged
Merged
Conversation
Two default Chiefs both store the blue whale, so a friend row named Chief drew the same picture as the local Chief. Step that published preset when the display names match. The local Bot keeps its stored look, and a differently named friend keeps the picture it published. Fixes #1069 Co-authored-by: Danyang Chen <birfychen@gmail.com>
|
Verdict: PASS at 4ce59ea Ran:
Not run:
The defect test is red on the unbroken tip and green at this tip. A published preset that matches a local Bot of the same display name steps its shape; the local Bot's stored look is unchanged; a different name, a different look, an image, and an emoji stay. |
Collaborator
Author
|
Verdict: PASS at 4ce59ea Fixes #1069. Same-named friend Bot steps shape so it does not wear the local Bot look; local look unchanged. Regression in core/test/looks.test.js. No CHANGELOG.md / version (changelog.d fragment only). No risk:T* label. Ran:
|
This was referenced Oct 25, 2026
cursor Bot
pushed a commit
that referenced
this pull request
Oct 25, 2026
Keep the #1058 task board and take main's same-name friend look (#1069 / #1078) and the Revoke confirmation (#1073 / #1079). The generated client-bundle hunk header was the conflict; the bundle was rebuilt from the merged client sources and the patch regenerated so it applies. Fixes #1058 Co-authored-by: Danyang Chen <birfychen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Owner: Birfy
Reviewer: Reviewer
Fixes #1069
What changed
A friend Bot that shares a local Bot's display name was drawn with that local Bot's picture. Two default Chiefs both store the blue whale, and
lookAvoidingLocalsleft a published preset alone, so the friend row and the local Chief were the same avatar. The orange Main Bot star and the globe after the friend name were the only differences.A published preset now steps its shape when it is the same drawn look as a local Bot of the same display name. The local Bot keeps its stored look. A differently named friend keeps the picture it published. An image or emoji stays.
The draw decision is
lookAvoidingLocalsincore/src/client/characters.js, used byBotMark.Verification at the tip
Tip SHA: 4ce59ea
Defect test:
a friend Bot that shares a display name does not wear that local Bot's look (#1069)failed on the unbroken tip (same display name must not share the drawn look,core/test/looks.test.js) and passes at this tip.Ran:
node --import ./test/harness-resolve.mjs --test --test-name-pattern '#1069' test/looks.test.json the unbroken tip — fail (1).TZ=UTC npm run verifyon Node v22.23.4 — pass. arch-docs OK (10 files). core 1412, social 453, tree 125, timeline 125, github scripts 417, interop 37, live-e2e 16.node scripts/ds-bot-patches.mjs check— pass (inside verify).Not run (and why):
dev/bench.shsmoke. Display-only client code. Nocore/index.jsorcore/src/host/change.No
CHANGELOG.mdedit and no version bump. User-visible note ischangelog.d/1069-friend-chief-avatar.fixed.md.