Repository navigation
fix: respect tiling window managers better on linux - #467
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe layout window now enables resizing on Linux. Other platform behavior remains unchanged. ChangesLinux window behavior
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Linux layout window can now be resized as intended, with no concrete merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit hops where Linux tiles, Comment |
|
No docstrings were modified or new functions created that need to be documented. Why am I being requested to fix docstrings? |
DirkDoes
left a comment
There was a problem hiding this comment.
Thanks.
Adding it in thte app right now so it works smoothly with the tiling feature.
We are going to revisit the window behavior soon, so it might change later again, but it sounds like we wanna keep this behavior
* Preserve settings files and report persistence failures * Make settings values type safe and centralize path reloads * l10n: Spanish full translation update & improvements (#471) Updated yml to include new l10n on latest version of WhWz (v2.5.7), plus some mistake corrections on a few existing translations. Translation support is now back to 100%. * i10n: Update German translation (#481) * i10n: Update German translation * fix: Update name * l10n: Add missing German translations (#487) * l10n: Add missing German translations * l10n: Fix mistranslation of "scaling" * l10n: Fix issues in code review * l10n: Add translation for "polish" string --------- Co-authored-by: Dirk <dirkroosendaal04@gmail.com> * l10n: Add localization support to Leaderboard page (#464) * l10n(leaderboard): Add l10n to basic strings * l10n(leaderboard): Add l10n to placements * l10n(leaderboard): Add l10n to snackbar messages * l10n(leaderboard): Add German translations * l10n: Fix rank labels not using localization * l10n: Fix retry/refresh buttons not using localization * l10n(Leaderboard): Translate unknown Mii name * l10n(Leaderboard): Use localization for podium placements * l10n(Leaderboard): Fix German retry/refresh translation * fix(LeaderboardPodiumCard): Make placement a Avalonia property --------- Co-authored-by: WantToBeeMe | Dirk <dirkroosendaal04@gmail.com> * i18n: import Czech, Spanish and Finnish translations (#507) * fix: remove unused build scripts (#497) * fix: respect tiling window managers better on linux (#467) Co-authored-by: Dirk <dirkroosendaal04@gmail.com> * Preserve settings files and report persistence failures * Propagate recommended settings save failures * Recalculate virtual settings after partial save failures * Preserve settings files and report persistence failures (#498) * Preserve settings files and report persistence failures * Propagate recommended settings save failures * Recalculate virtual settings after partial save failures --------- Co-authored-by: Asier Septién <yoshimanbiz@gmail.com> Co-authored-by: Arthur <creeperkatze.dev@gmail.com> Co-authored-by: TheJanzap <16736682+TheJanzap@users.noreply.github.com> Co-authored-by: Jack Tench <79285604+JackTench@users.noreply.github.com>
Purpose of this PR:
Allows the window of WheelWizard to be resizable on Linux.
This helps better support users of tiling window managers.
How to Test:
Build project, test on a system using a tiling WM.
What Has Been Changed:
In Layout.axaml.cs, CanResize is set to true if running on Linux.
Related Issue Link:
N/A
Checklist before merging
Summary by CodeRabbit