Skip to content

fix: respect tiling window managers better on linux - #467

Merged
DirkDoes merged 2 commits into
TeamWheelWizard:mainfrom
JackTench:main
Oct 4, 2026
Merged

DirkDoes merged 2 commits into
TeamWheelWizard:mainfrom
JackTench:main

Conversation

@JackTench

@JackTench JackTench commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Purpose of this PR:

Allows the window of WheelWizard to be resizable on Linux.
This helps better support users of tiling window managers.

How to Test:

Build project, test on a system using a tiling WM.

What Has Been Changed:

In Layout.axaml.cs, CanResize is set to true if running on Linux.

Related Issue Link:

N/A

Checklist before merging

  • You have created relevant tests

Summary by CodeRabbit

  • New Features
    • Linux users can now resize the application window, including when using tiling window managers.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 518dd4e3-653c-4c64-ba78-ab7676fd1564

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 561133e8-378a-45e7-bf02-286674630849

📥 Commits

Reviewing files that changed from the base of the PR and between af75a62 and ebf30aa.

📒 Files selected for processing (1)
  • WheelWizard/Views/Layout.axaml.cs

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The layout window now enables resizing on Linux. Other platform behavior remains unchanged.

Changes

Linux window behavior

Layer / File(s) Summary
Linux resize configuration
WheelWizard/Views/Layout.axaml.cs
The Layout constructor sets CanResize = true when RuntimeInformation.IsOSPlatform(OSPlatform.Linux) returns true.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: dirkdoes

Merge Risk: ⚪ Minimal · up to ebf30

The Linux layout window can now be resized as intended, with no concrete merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: improved Linux support for tiling window managers.
Description check ✅ Passed The description includes the required sections and explains the purpose, testing method, code change, and issue status. The test checklist remains unchecked, which is acceptable because the objectives…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit hops where Linux tiles,
The window grows by little miles.
CanResize wakes with a cheer,
Edges move wide and edges move near.
The layout fits with nimble grace.

Comment @coderabbitai help to get the list of available commands.

@JackTench

Copy link
Copy Markdown
Contributor Author

No docstrings were modified or new functions created that need to be documented. Why am I being requested to fix docstrings?

@DirkDoes DirkDoes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Adding it in thte app right now so it works smoothly with the tiling feature.
We are going to revisit the window behavior soon, so it might change later again, but it sounds like we wanna keep this behavior

@DirkDoes
DirkDoes merged commit 646ca7e into TeamWheelWizard:main Oct 4, 2026
3 checks passed
DirkDoes added a commit that referenced this pull request Oct 4, 2026
* Preserve settings files and report persistence failures

* Make settings values type safe and centralize path reloads

* l10n: Spanish full translation update & improvements (#471)

Updated yml to include new l10n on latest version of WhWz (v2.5.7), plus some mistake corrections on a few existing translations.
Translation support is now back to 100%.

* i10n: Update German translation (#481)

* i10n: Update German translation

* fix: Update name

* l10n: Add missing German translations (#487)

* l10n: Add missing German translations

* l10n: Fix mistranslation of "scaling"

* l10n: Fix issues in code review

* l10n: Add translation for "polish" string

---------

Co-authored-by: Dirk <dirkroosendaal04@gmail.com>

* l10n: Add localization support to Leaderboard page (#464)

* l10n(leaderboard): Add l10n to basic strings

* l10n(leaderboard): Add l10n to placements

* l10n(leaderboard): Add l10n to snackbar messages

* l10n(leaderboard): Add German translations

* l10n: Fix rank labels not using localization

* l10n: Fix retry/refresh buttons not using localization

* l10n(Leaderboard): Translate unknown Mii name

* l10n(Leaderboard): Use localization for podium placements

* l10n(Leaderboard): Fix German retry/refresh translation

* fix(LeaderboardPodiumCard): Make placement a Avalonia property

---------

Co-authored-by: WantToBeeMe | Dirk <dirkroosendaal04@gmail.com>

* i18n: import Czech, Spanish and Finnish translations (#507)

* fix: remove unused build scripts (#497)

* fix: respect tiling window managers better on linux (#467)

Co-authored-by: Dirk <dirkroosendaal04@gmail.com>

* Preserve settings files and report persistence failures

* Propagate recommended settings save failures

* Recalculate virtual settings after partial save failures

* Preserve settings files and report persistence failures (#498)

* Preserve settings files and report persistence failures

* Propagate recommended settings save failures

* Recalculate virtual settings after partial save failures

---------

Co-authored-by: Asier Septién <yoshimanbiz@gmail.com>
Co-authored-by: Arthur <creeperkatze.dev@gmail.com>
Co-authored-by: TheJanzap <16736682+TheJanzap@users.noreply.github.com>
Co-authored-by: Jack Tench <79285604+JackTench@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants