Repository navigation
Stop the backspace drag test from toggling the pre-restart keyboard - #45
Merged
Merged
Conversation
… the backspace drag test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alpha16 drag-preview timing fix hardened
BackspaceSelectionTestagainst the asynchronous IME rebuild that followssetText/restartInput, but one door was left open:livePanelOpenImmediatelyRefusesSelectionGesturepressed the new expand chevron before the rebuilt keyboard was live, so on CI the toggle could land on the pre-restart panel and the test then failed with "The panel did not reveal its accessory keys". This surfaced as the single post-merge failure onmain(run 35037505286) after PR #44.The test now waits for the post-restart Delete button to settle (the same
stableDelete()two-poll guard the drag paths already use) before pressing the chevron. Test-only change; production code is untouched.Verified locally on UtterleafFoundation35 (API 35):
BackspaceSelectionTestpasses 10/10.Implemented by opencode (openrouter/z-ai/glm-5.3-flash) in T3 Code.