Repository navigation
Wait for the rebuilt keyboard before using the extra-keys panel in editor tests - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async-IMI-restart race that PR #45 fixed for the backspace drag and its panel toggle has a third surface:
KeyboardEditorContractTestpresses the new "Extra keys" chevron immediately aftersetText, and on a slow CI emulator the toggle can land on the pre-rebuild keyboard — the rebuild then discards the open panel and the test fails with "Missing Forward delete" (observed once on main, run 35190589034, after PR #47).KeyboardEditorContractTestgains anopenExtraKeys()helper: press the chevron, wait up to 3 s for the panel's accessory keys to actually appear, and retry (bounded, 15 s overall) if a rebuild swallowed the toggle. The two tests that drive the panel now use it. Test-only change; production code untouched.Verified locally on UtterleafFoundation35 (API 35):
KeyboardEditorContractTestpasses 3/3.Implemented by opencode (openrouter/z-ai/glm-5.3-flash) in T3 Code.