refactor(planner): add explicit precompute physical plan - #469
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PhysicalPlanwithCollectorPlan,PrecomputePlan, andBackendPlanprojections sharing one plan envelopePrecomputePlanas config-driven materializations, with no PromQL job or scheduler-shaped fieldsPrecomputeJobemitter/client, protobuf field, in-memory backend registry, and/api/v1/precompute*job endpoints that acknowledged work without scheduling itExecution model
PrecomputePlan.materializationsdrives metric/filter matching, accumulator selection, grouping, windows, and SketchStore writes through/api/v1/streaming-config. Query readouts and routing DAG remain exclusively inBackendPlan.Validation
cargo test -p control_plane— 678 lib + 28 API tests passed; 3 doc tests ignoredcargo test -p data_plane drivers::query::servers::http --lib— 60 passed; 1 ignoredcargo check -p control_plane -p data_planegit diff --checkStacked on #468.