Skip to content

refactor(query): replace analyzer routing with BackendPlan DAG resolver - #468

Merged
zzylol merged 1 commit into
mainfrom
feat/backend-plan-dag-routing
Sep 3, 2026
Merged

zzylol merged 1 commit into
mainfrom
feat/backend-plan-dag-routing

Conversation

@zzylol

@zzylol zzylol commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the legacy ASAPTierCandidate analyzer from both instant and range warm-routing paths
  • route each warm query through one authoritative pipeline: ASAPPlanner post-ASAP DAG, BackendPlan materialization validation, SID resolution, and recursive DAG execution
  • derive instant lookback, cumulative readout, and full-history sum semantics from Planner IR instead of analyzer fields
  • preserve safe fallback for rate/irate, counter sum_over_time, keyed frequency, unsupported DAG operators, missing routes, missing SIDs, and family/parameter mismatches
  • return typed resolver/executor reasons through CapabilityMiss so EngineRouter falls through to Thanos
  • preserve capability-miss notifications and the warm/archive coverage stitch

Verification

  • cargo test -p data_plane query_engines::asap_query_engine --lib (90 passed)
  • cargo test -p control_plane --lib (688 passed)
  • cargo test -p data_plane --test e2e_controller_plans_and_backend_serves controller_really_pushes_backend_plan_and_query_really_serves (passed)
  • git diff --check
  • no ASAPTierCandidate/analyze_promql_for_asap_tier/find_matching_policies references remain in the query-engine serving path

A stricter local cargo clippy -D warnings remains blocked by pre-existing control-plane warnings outside this change.

Stack

Depends on #467.

@zzylol
zzylol changed the base branch from refactor/remove-sketch-algebra to main September 3, 2026 02:54
@zzylol
zzylol merged commit 6957e69 into main Sep 3, 2026
1 check passed
@zzylol
zzylol deleted the feat/backend-plan-dag-routing branch September 12, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant