Skip to content

fix(planner): make BackendPlan authoritative for warm execution - #470

Merged
zzylol merged 1 commit into
mainfrom
fix/physical-plan-correctness
Sep 3, 2026
Merged

zzylol merged 1 commit into
mainfrom
fix/physical-plan-correctness

Conversation

@zzylol

@zzylol zzylol commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the legacy ASAP-tier analyzer with ASAPPlanner post-ASAP planning
  • resolve each SummaryAgg against exact BackendPlan materializations before SID lookup/DAG execution
  • fail closed on filter, grouping, window, family/parameter, route, and generation mismatches
  • remove legacy UNSET-fingerprint authorization and arbitrary first-family selection
  • publish streaming config, BackendPlan, and storage routing through one atomic PhysicalPlan API
  • strengthen BackendPlan validation and add generation fencing
  • make PhysicalCompiler consume post-ASAP IR and retain an explicit planner adapter

Validation

  • cargo check -p control_plane -p data_plane
  • cargo test -p control_plane --bin control_plane
  • cargo test -p control_plane emit::backend_push::tests --lib
  • cargo test -p control_plane backend_plan --lib
  • cargo test -p data_plane post_asap --lib
  • cargo test -p data_plane storage_engines::types::hot_reload_config --lib
  • persistence index tests pass serially (parallel full-suite run exposes existing timing flakes)

Stacked on #469.

@zzylol
zzylol force-pushed the fix/physical-plan-correctness branch 2 times, most recently from e77424a to 56c9da1 Compare September 3, 2026 02:19
@zzylol
zzylol force-pushed the fix/physical-plan-correctness branch from 56c9da1 to 152ec57 Compare September 3, 2026 02:34
@zzylol
zzylol changed the base branch from refactor/remove-dead-precompute-jobs to main September 3, 2026 02:54
@zzylol
zzylol merged commit 150fff3 into main Sep 3, 2026
1 check passed
@zzylol
zzylol deleted the fix/physical-plan-correctness branch September 12, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant