chore(telegraf-patch): delete deprecated aggregator scaffolding - #244
Merged
Merged
Conversation
The processors.allsketches unified plugin (PR #237) supersedes the older per-sketch aggregator-based attempt at Telegraf integration. Remove the dead scaffolding: - telegraf-patch/plugins/aggregators/{ddsketch,kll,countmin,gorilla,sketchutil}/ - telegraf-patch/plugins/aggregators/all/* (registration overlays) - telegraf-patch/plugins/outputs/gorilla_s3/ (was wired to deleted gorilla) Restore script and build pipeline already skip these per PR #240. Three stale reference comments updated (matched_accuracy/main.go, matched_accuracy/README.md, design-asap-edge-framework.md §7 table). Net: 2420 LoC removed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
force-pushed
the
phase4/delete-deprecated-aggregators
branch
from
May 5, 2026 01:17
7feed13 to
8eb430d
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The unified
processors.allsketchesplugin (PR #237) supersedes the older per-sketch aggregator-based attempt at Telegraf integration. The scaffolding undertelegraf-patch/plugins/aggregators/was already excluded from the build pipeline by PR #240. This PR removes the dead source.Deleted:
telegraf-patch/plugins/aggregators/{ddsketch,kll,countmin,gorilla,sketchutil}/telegraf-patch/plugins/aggregators/all/(registration overlays)Kept (per review):
telegraf-patch/plugins/outputs/gorilla_s3/— standalone Telegraf output plugin with noasap-precompute-go/sketchlib-godependency. Independent of the common library; not part of the aggregator cleanup.Updated stale references:
otel_collector_benchmark/matched_accuracy/main.go— comment removed file-path referenceotel_collector_benchmark/matched_accuracy/README.md— samedocs/design-asap-edge-framework.md§7 — table row updated to reflectprocessors.allsketchesshaperestore_telegraf_patches.sh— header comment updatedNet: ~2010 LoC removed (down from 2420 after gorilla_s3 restore).
Test plan
go build ./...inotel_collector_benchmark/matched_accuracy/./build_sketchtelegraf.shproduces working binary withallsketchesregistered🤖 Generated with Claude Code