Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/design-asap-edge-framework.md
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ Per-platform compile-in mechanism (all Tier 2):
| Platform | Mechanism | Distribution unit |
|---|---|---|
| **OTel Collector** | OCB (OpenTelemetry Collector Builder) reads `builder-config.yaml`, compiles in custom processors at build time. ASAPCollector already does this. | `sketchcollector` |
| **Telegraf** | `plugins/aggregators/all/asap.go` + build tag in `plugins/aggregators/all/aggregators.go`. No `aggregators.execd` exists. | `sketchtelegraf` |
| **Telegraf** | `plugins/processors/all/allsketches.go` build-tag overlay registering the unified `processors.allsketches` plugin. | `sketchtelegraf` |
| **Vector** | In-tree feature flag + `inventory::submit!` registration in a path-dependency Cargo workspace. | `sketchvector` |
| **OTAP Dataflow** | `linkme` distributed-slice compile-time registration; the project README states "current system is compile-time only." | `sketchotap` |

Expand Down
7 changes: 2 additions & 5 deletions otel_collector_benchmark/matched_accuracy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,8 @@ binary marshaller — you'd ship the centroid array yourself).

### what got skipped

* **Gorilla.** A Gorilla codec exists at
`telegraf-patch/plugins/aggregators/gorilla/`, but it's
1. wrapped in Telegraf's plugin interface (needs `telegraf.Metric`,
`time.Time`, etc.), and
2. **a (timestamp, value) lossless compressor, not a quantile sketch.**
* **Gorilla.** Gorilla is **a (timestamp, value) lossless compressor,
not a quantile sketch.**

In a matched-p99-error table Gorilla either has to store every sample (in
which case its wire size is necessarily larger than DDSketch / KLL by
Expand Down
4 changes: 1 addition & 3 deletions otel_collector_benchmark/matched_accuracy/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@
// 6. Raw samples – inline (count = N*8 bytes)
// 7. Gorilla – SKIPPED. See rationale below.
//
// On Gorilla: the only Gorilla codec available locally lives in
// telegraf-patch/plugins/aggregators/gorilla/ and is wrapped in a Telegraf
// aggregator. More importantly, Gorilla is a (timestamp,value) lossless
// On Gorilla: Gorilla is a (timestamp,value) lossless
// compression scheme for sequential time-series points; it does not estimate
// quantiles. Including it in a "matched p99 error" comparison would mean
// either feeding it synthetic timestamps and storing every sample (in which
Expand Down
9 changes: 3 additions & 6 deletions restore_telegraf_patches.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,9 @@
# binary (Telegraf is a single-module repo). The script therefore
# excludes go.mod / go.sum when staging into the submodule.
#
# Pre-`allsketches` experimental patches under telegraf-patch/plugins/
# (aggregators/ddsketch, aggregators/kll, outputs/gorilla_s3, …) are
# superseded by the unified `allsketches` plugin per the design doc and
# are intentionally NOT copied — their dependencies were never wired
# into Telegraf's go.mod and they no longer build. They remain in
# telegraf-patch/ as archaeology.
# Pre-`allsketches` experimental aggregator/output patches were
# deleted in the cleanup that landed alongside this script — the
# unified `allsketches` plugin supersedes them per the design doc.
#
# Idempotent: re-running re-copies files; no-ops if patches don't differ.
set -euo pipefail
Expand Down
5 changes: 0 additions & 5 deletions telegraf-patch/plugins/aggregators/all/countmin.go

This file was deleted.

5 changes: 0 additions & 5 deletions telegraf-patch/plugins/aggregators/all/ddsketch.go

This file was deleted.

5 changes: 0 additions & 5 deletions telegraf-patch/plugins/aggregators/all/gorilla.go

This file was deleted.

5 changes: 0 additions & 5 deletions telegraf-patch/plugins/aggregators/all/kll.go

This file was deleted.

262 changes: 0 additions & 262 deletions telegraf-patch/plugins/aggregators/countmin/countmin.go

This file was deleted.

27 changes: 0 additions & 27 deletions telegraf-patch/plugins/aggregators/countmin/sample.conf

This file was deleted.

Loading