cleanup(deploy/configs): drop legacy aggregationId from backend-streaming fixtures - #378
Merged
zzylol merged 1 commit intoMay 15, 2026
Conversation
…ming fixtures
PR 5 in asapquery-backend retired the controller-allocated
`aggregationId` field — identity is now content-addressed via
`PolicyFingerprint(u64)` derived from the aggregation's content.
The backend's `AggregationConfig::from_yaml_data` silently drops
`aggregationId` on read; these four fixtures still carried the
field as a stale exemplar.
Cosmetic only — behaviour is unchanged because the backend already
tolerates the field. Updates align the fixtures with the current
controller emit shape and prevent the field from being copied into
new YAMLs by authors using these as templates.
Touched: backend-streaming-{kll,hll,cs,cms}.yaml.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 5 in asapquery-backend retired the controller-allocated
aggregationIdfield — identity is now content-addressed viaPolicyFingerprint(u64). The backend'sAggregationConfig::from_yaml_datasilently dropsaggregationIdon read; these four fixtures still carried the field as a stale exemplar.Cosmetic only — behaviour is unchanged because the backend already tolerates the field. Updates align the fixtures with the current controller emit shape (see asapquery-backend #244) and prevent the field from being copied into new YAMLs by authors using these as templates.
Files
deploy/mvp-singlenode/configs/backend-streaming-kll.yamldeploy/mvp-singlenode/configs/backend-streaming-hll.yamldeploy/mvp-singlenode/configs/backend-streaming-cs.yamldeploy/mvp-singlenode/configs/backend-streaming-cms.yamlTest plan
/api/v1/streaming-configstill parses these fixtures (it does — backend has tolerated the field for many releases).🤖 Generated with Claude Code