Skip to content

Extensions: Fix options and allow passing functions to the end_command - #48

Merged
jmwohl merged 2 commits into
OpenframeProject:masterfrom
jvolker:fixExtensionOptions
Sep 28, 2019
Merged

jmwohl merged 2 commits into
OpenframeProject:masterfrom
jvolker:fixExtensionOptions

Conversation

@jvolker

@jvolker jvolker commented Sep 24, 2019 •

Copy link
Copy Markdown
Collaborator

Fixes #47

@jmwohl

jmwohl commented Sep 27, 2019

Copy link
Copy Markdown
Member

This PR overlaps with your #46 — can you either close that one or remove that commit from this one?

@jvolker jvolker changed the title Fix extension options Extensions: Fix options and allow passing functions to the end_command Sep 27, 2019
@jvolker

jvolker commented Sep 27, 2019

Copy link
Copy Markdown
Collaborator Author

Yeah, I'm still a bit new to pull requests. Removed the other PR. Thanks.

@jmwohl
jmwohl merged commit fec2275 into OpenframeProject:master Sep 28, 2019
@jvolker
jvolker deleted the fixExtensionOptions branch September 30, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Artwork settings/options property name differs from API

2 participants