Skip to content

Artwork settings/options property name differs from API #47

Closed

Description

@jvolker

The client currently uses a property of artwork called settings whereas the API returns options. Those need to be aligned. Because of this, it's currently not possible to forward options/settings to an extension.

@jmwohl could you please give direction on which one of them should be used? I am happy to do those changes.

Activity

  1. jvolker commented on Sep 24, 2019

    @jvolker
    CollaboratorAuthor

    BTW in https://github.com/OpenframeProject/Openframe-Video/blob/master/README.md it's even called config. I can fix that too.

  2. jvolker commented on Sep 24, 2019

    @jvolker
    CollaboratorAuthor

    Since they are optional I thought options is probably a good term and will create a pull request.

  3. added a commit that references this issue on Sep 24, 2019
    68cf360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions