Skip to content

Allow to pass functions to the end_command in extensions #43

Closed

Description

@jvolker

Sometimes it's necessary to do some cleanup tasks after finishing to show some artwork.

While it's currently possible to run a shell script by passing a string via the end_command property, it would be nice to do this directly in Node.Js by passing a function instead. Just like it's possible forstart_command.

I had a quick look into the code, and it seems it's only necessary to copy a few lines of code to allow this.

Thanks.

Activity

  1. jmwohl commented on Sep 23, 2019

    @jmwohl
    Member

    Yeah, I don't see a reason not to support this... feel free to submit a PR!

  2. added a commit that references this issue on Sep 23, 2019
    0ca5fa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions