Repository navigation
docs: clarify skill contributions and ownership - #77
Merged
Merged
Conversation
abretonc7s
marked this pull request as ready for review
July 27, 2026 14:29
abretonc7s
enabled auto-merge (squash)
July 27, 2026 14:53
Move the CONTRIBUTING rewrite under Changed, and show install examples for multiple consumer repos.
NicolasMassart
approved these changes
Jul 28, 2026
NicolasMassart
left a comment
NicolasMassart
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
MajorLift
added a commit
that referenced
this pull request
Jul 30, 2026
#77 landed the contribution-doc corrections this branch was carrying — clone URL, `domains/<area>/skills/` layout, lowercase `skill.md`, `repos/` overlays — and rewrote `SKILL_TEMPLATE.md` independently. Both files resolve to main's version rather than reapplying work already merged. What remains unique is the pull-request template, which still asks for **Provider Name:** — a field from the pre-domain layout that no longer exists. It becomes **Domain:**.
andrepimenta
added a commit
that referenced
this pull request
Sep 7, 2026
Step 2 of docs/processes/releasing.md — "review the generated CHANGELOG.md section and keep entries consumer-facing". The generated section needed it in two places. `### Uncategorized` held ten merged PRs that never got a hand-written entry. Since `package.json` `files` ships `domains/` alongside `bin/` and `tools/`, skill content reaches consumers on upgrade, so most of these are genuinely user-facing and belong in the notes rather than being dropped. Rewritten from the consumer's point of view and grouped by theme rather than one line per PR: the component-view testing work (#109, #115, #132) reads as one change, as does the Mobile testing default plus the Appium playbook move (#70, #54). Dropped #63 and #77 — `.cursor` review rules and `.github`/`CONTRIBUTING` changes are not in the published package, so an upgrading consumer sees nothing of them. `### Added` had the same problem less visibly: around a dozen raw conventional-commit titles (`feat: add ...`, `feat(cli): ...`) that read as commit log rather than release notes. Prefixes stripped, past tense applied. Three were duplicates of curated entries for the same PR (#136, #75, and the component-view flakiness line now covered by the #109 entry) and were removed. Verified: `lint:changelog` passes, 69/69 tests, lint clean, `pack:dry-run` ok. No `Uncategorized` section and no conventional-commit prefixes remain. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the contribution guide and skill template to match the current repository layout. Adds complete domain ownership so reviews route to the responsible MetaMask teams.
Repository admins must grant listed teams explicit write access for GitHub to enforce team ownership.
Type of Change
Checklist
Testing
yarn test— 41 tests passedyarn lintgit diff --check