Repository navigation
docs(testing): CV-default Mobile testing layers - #70
Merged
Merged
Conversation
Add shared testing-layers policy and align Mobile coding, PR, unit, and CV skills so agents prefer *.view.test.tsx and use unit tests as fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: João Tavares <joao.tavares@consensys.net>
Contributor
Author
|
Thanks for the linked resources in the PR description suggestion @cryptotavares! |
racitores
enabled auto-merge (squash)
July 22, 2026 13:31
pnarayanaswamy
approved these changes
Jul 22, 2026
racitores
added a commit
that referenced
this pull request
Jul 27, 2026
Extend the CV-default guidance from #70 across coding, PR-workflow, and perps review skills so app-to-controller flows are steered to the integration layer under the best-fit-layer model. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 30, 2026
andrepimenta
added a commit
that referenced
this pull request
Sep 7, 2026
Step 2 of docs/processes/releasing.md — "review the generated CHANGELOG.md section and keep entries consumer-facing". The generated section needed it in two places. `### Uncategorized` held ten merged PRs that never got a hand-written entry. Since `package.json` `files` ships `domains/` alongside `bin/` and `tools/`, skill content reaches consumers on upgrade, so most of these are genuinely user-facing and belong in the notes rather than being dropped. Rewritten from the consumer's point of view and grouped by theme rather than one line per PR: the component-view testing work (#109, #115, #132) reads as one change, as does the Mobile testing default plus the Appium playbook move (#70, #54). Dropped #63 and #77 — `.cursor` review rules and `.github`/`CONTRIBUTING` changes are not in the published package, so an upgrading consumer sees nothing of them. `### Added` had the same problem less visibly: around a dozen raw conventional-commit titles (`feat: add ...`, `feat(cli): ...`) that read as commit log rather than release notes. Prefixes stripped, past tense applied. Three were duplicates of curated entries for the same PR (#136, #75, and the component-view flakiness line now covered by the #109 entry) and were removed. Verified: `lint:changelog` passes, 69/69 tests, lint clean, `pack:dry-run` ok. No `Uncategorized` section and no conventional-commit prefixes remain. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make component-view the default MetaMask Mobile test layer for screen/view UI behavior, with unit as a focused fallback and e2e for device journeys.
domains/testing/knowledge/testing-layers.md(installed beside testing skills)coding-guidelines,unit-testing,component-view-test,pr-guidelines, andpr-readiness-checkperps-review-prat the shared layers policy (keep Perps-specific path enforcement)e2e-testskill migration is out of scopeSome more context about the reason:
https://kentcdodds.com/blog/the-testing-trophy-and-testing-classifications (creator of testing-library)
https://x.com/swyx/status/1261202288476971008
Type of Change
Skill Details (if adding a new skill)
Provider Name:
Skill Name:
Brief Description:
Checklist
Testing
domains/testing/knowledge/beside testing-domain skills (copy_domain_knowledge)Additional Context
Mobile-only. Extension overlays unchanged. The detailed Detox→Appium rewrite of
e2e-testremains a follow-up.Made with Cursor