Repository navigation
docs(testing): await async-gated content in CV tests - #115
Merged
Merged
Conversation
Document the pattern where a container mounts before a child value settles (query/debounce/skeleton), so agents await the gated value instead of racing with a sync getBy* under CI load. Co-authored-by: Cursor <cursoragent@cursor.com>
racitores
enabled auto-merge (squash)
August 7, 2026 16:15
javiergarciavera
approved these changes
Aug 7, 2026
MajorLift
added a commit
that referenced
this pull request
Aug 31, 2026
The 25 conflicts were all in files this branch picked up when #97 merged in, never in its own `domains/stability/` content. `main` has since carried five more commits over those same files — #109, #115, #54, #120, #132 — against this branch's single snapshot of them, so `main` is authoritative for every one and its version is taken throughout. That includes six deletions: #120 dropped Detox E2E, and the four `references/detox/` files plus `detox-to-appium.md` and `detox/legacy-playbook.md` go with it. Nothing references them. The merged tree now differs from `main` only in the `CODEOWNERS` line this PR adds and its five `domains/stability/` files.
andrepimenta
added a commit
that referenced
this pull request
Sep 7, 2026
Step 2 of docs/processes/releasing.md — "review the generated CHANGELOG.md section and keep entries consumer-facing". The generated section needed it in two places. `### Uncategorized` held ten merged PRs that never got a hand-written entry. Since `package.json` `files` ships `domains/` alongside `bin/` and `tools/`, skill content reaches consumers on upgrade, so most of these are genuinely user-facing and belong in the notes rather than being dropped. Rewritten from the consumer's point of view and grouped by theme rather than one line per PR: the component-view testing work (#109, #115, #132) reads as one change, as does the Mobile testing default plus the Appium playbook move (#70, #54). Dropped #63 and #77 — `.cursor` review rules and `.github`/`CONTRIBUTING` changes are not in the published package, so an upgrading consumer sees nothing of them. `### Added` had the same problem less visibly: around a dozen raw conventional-commit titles (`feat: add ...`, `feat(cli): ...`) that read as commit log rather than release notes. Prefixes stripped, past tense applied. Three were duplicates of curated entries for the same PR (#136, #75, and the component-view flakiness line now covered by the #109 entry) and were removed. Verified: `lint:changelog` passes, 69/69 tests, lint clean, `pack:dry-run` ok. No `Uncategorized` section and no conventional-commit prefixes remain. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mobile-testingcomponent-view refs.PredictMarketDetailsPositions-tab$60failure on metamask-mobilemainCI (syncgetByTextafter awaiting only the tab container).Test plan
yarn audit:skills— 0 errorsyarn test— 61/61 passMade with Cursor