fix: replace standalone SBOM with reusable quality workflow - #193
Merged
Conversation
- Koppeling type field: "intern" → "api" (valid enum value) - #452: Search for existing test app instead of non-existent Makelaarsuite - #435: Lower leverancier app threshold from 50 to 25 (matches actual data) - #344: Handle empty referentieComponenten facet gracefully - #144: Make publications field check more robust - Update API test results (454/454 passing)
The frontend expects a menu at position 7 for the beheer sidebar. Without it, all beheer pages show empty content with "Beheer menu (position 7) not found or has no items".
ObjectEntityMapper was removed from OpenRegister during the retire-blob-objects-table change. All 11 references in 4 files updated to use MagicMapper (drop-in replacement, same interface). Files: ContactpersoonService, ContactpersonenController, OrganizationSyncService, UserProfileUpdatedEventListener
…flow Replace standalone code-quality.yml and sbom.yml with a single code-quality.yml that calls ConductionNL/.github quality.yml reusable workflow with enable-sbom and enable-frontend options.
Accept development's test-setup.sh, postman tests, and package-lock. Merge code-quality.yml: keep development's full config, add enable-sbom, fix nextcloud-ref to nextcloud-test-refs.
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (120 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-quality.yml(matrix of PHP checks + frontend quality) and standalonesbom.ymlwith a singlecode-quality.ymlthat calls theConductionNL/.githubreusable quality workflow withenable-sbom: trueandenable-frontend: trueContactpersonenController,ContactpersoonService,OrganizationSyncService, andUserProfileUpdatedEventListenerto use MagicMapper instead of removed ObjectEntityMappertest-setup.shscript that creates the beheer menu at position 7GOVERNMENT-FEATURES.mddescribing government-specific capabilitiescomposer.json,composer.lock,package.json,package-lock.json; added PHPUnit config (phpunit-unit.xml) and updated Psalm configCommits
4df1775fix: consolidate quality and SBOM workflows into single reusable workflowfa4f836fix: replace standalone SBOM workflow with reusable quality workflow9c478befix: Replace ObjectEntityMapper references with MagicMapper10fed8dfix: Add beheer menu (position 7) creation to test setup69ac476fix: Correct Postman test data and thresholds for passing API suite