fix: Fix PHPUnit tests for CI - #190
Closed
rubenvdlinde wants to merge 9 commits into
Closed
Conversation
Dev to main
[skip ci]
# Conflicts: # appinfo/info.xml
[skip ci]
rubenvdlinde
force-pushed
the
fix/phpunit-tests
branch
from
March 13, 2026 14:23
41bbdf6 to
1deb66d
Compare
Contributor
Quality Report
See workflow run for details. |
- Migrate code-quality.yml to ConductionNL reusable quality workflow - Replace createMock(ObjectEntity) with getMockBuilder()->addMethods() for __call magic methods - Fix ContactpersonenController mock constructor argument order (add IUserSession, ContainerInterface) - Fix ContactPersonHandler mock constructor (9 args instead of 4) - Remove integration tests from phpunit.xml (need running server, belong in Newman) - Make bootstrap.php resilient to missing Nextcloud environment
rubenvdlinde
force-pushed
the
fix/phpunit-tests
branch
from
March 13, 2026 14:26
1deb66d to
5e81d24
Compare
Contributor
Quality Report
See workflow run for details. |
- Split ObjectEntity mock methods: onlyMethods for real methods (getObject), addMethods for magic __call methods (getSchema, getId, etc.) - Delete EmailServiceTest (EmailService class doesn't exist) - Fix testHandleEventWithNullObject to use mock instead of null - Fix testPasswordChangeWithInvalidUser broken mock expectation
Contributor
Quality Report
See workflow run for details. |
- jsonSerialize exists on ObjectEntity (via parent), move to onlyMethods - Split testAddUserToGroupWithCheck into two tests to fix mock expectation conflict
Contributor
Quality Report
See workflow run for details. |
The workflow helper methods set up expects(once()) on mocks but never invoke the actual controller/service methods, causing guaranteed failures. Changed to method() (no call count expectation) since the mocks serve as data stubs for the assertion helpers.
Contributor
Quality Report
See workflow run for details. |
Contributor
Quality Report
See workflow run for details. |
Contributor
Author
|
Closing: the CI workflow change is superseded by #193 (reusable quality workflow, already merged). The PHPUnit mock fixes (createMock → getMockBuilder for ObjectEntity magic methods) are valuable but have too many conflicts against current development. These will be redone on a fresh cleanup branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createMock(ObjectEntity)withgetMockBuilder()->addMethods()for Entity__call()magic methodsTest plan
--testsuite "Integration Tests"locally