fix: Replace ObjectEntityMapper with MagicMapper - #192
Closed
rubenvdlinde wants to merge 6 commits into
Closed
Conversation
- Fix critical typo `isOpenRegisterInstalle === falsed(...)` → `isOpenRegisterInstalled(...) === false` that blocked Nextcloud upgrade cycle - Add 3 new Postman tests for #457 (koppeling deletion 400-error) - Fix #419 test auth (use admin credentials, move before session-bleeding tests) - Set lever_app_uuid in environment-local.json Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…n collection - Add bezoeker (public visitor) test results with screenshots - Update all role-based test results (architectuur-expert, functioneel-beheerder, gemeente, leverancier, samenwerking, security-officer) - Refresh API issue test results for 120+ issues - Expand Postman test collection with new test cases - Update test skills with additional test scenarios - Fix ContactpersoonService minor code update - Add issue #457 (koppeling delete 400 error) - Update issues.md and aanvullende-informatie.md
- ArchiMateExportService: fix 5 instances of `$this->isLis === falset(arr: ...)` to `$this->isList(arr: ...) === false` — was causing HTTP 500 on export (#135) - softwarecatalogus_register.json: add `"status": "Actief"` to all three public RBAC read rules for organisatie schema, preventing concept organisations from appearing in public search results (#447)
- Koppeling type field: "intern" → "api" (valid enum value) - #452: Search for existing test app instead of non-existent Makelaarsuite - #435: Lower leverancier app threshold from 50 to 25 (matches actual data) - #344: Handle empty referentieComponenten facet gracefully - #144: Make publications field check more robust - Update API test results (454/454 passing)
The frontend expects a menu at position 7 for the beheer sidebar. Without it, all beheer pages show empty content with "Beheer menu (position 7) not found or has no items".
ObjectEntityMapper was removed from OpenRegister during the retire-blob-objects-table change. All 11 references in 4 files updated to use MagicMapper (drop-in replacement, same interface). Files: ContactpersoonService, ContactpersonenController, OrganizationSyncService, UserProfileUpdatedEventListener
Contributor
Author
|
Closing: all changes in this PR were included in #193 (merged to development). The MagicMapper replacement, Postman test fixes, and beheer menu creation are all in development now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectEntityMapperwithMagicMapperMagicMapperis a drop-in replacement with the same interfaceTest plan
🤖 Generated with Claude Code