AUS-1002: Remove the obsolete InProcessClient - #163
Merged
Merged
Conversation
The obsolete InProcessClient wrapper leaves the core package in 2.0.0 as its own release-checklist item. The test that exercised JsonRpcProcessor.Process with a nullable float keeps its body under a name that says what it exercises. CHANGELOG and docs/upgrading.md carry the removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the ten 2.0.0 pull requests sequenced in AUS-1001 (https://linear.app/austins-test/issue/AUS-1001). Ticket: https://linear.app/austins-test/issue/AUS-1002
Json-Rpc/Client/InProcessJsonRpcClient.csdeleted: theInProcessClient.Invokewrapper has been obsolete since 1.x and forwarded toJsonRpcProcessor.Process; nothing in the tree calls it.TestInProcessClientrenamed toProcessStringOverloadNullableFloat; body and assertions unchanged.Verification on the branch: Release build 0 warnings / 0 errors; 1191 tests pass on net8.0 and net10.0;
check_request_path_sync.py23 listed uses, none unlisted;render.py --checkagrees; no request-path file touched, so no benchmark run. The core package packs with theClientfolder gone and its assemblies no longer contain the type.