Conversation
Names beginning with rpc. and the name $/cancelRequest are refused by one check in SMDServiceCollection (Add, the indexer setter and AddBatch before any entry is copied), which every registration path reaches: BindMethod, the attribute binder and RegisterFuction through AddService, BindInterface through AddBatch. BindInterface drops its own rpc. test. An internal AddReserved keeps the duplicate rule for the library's later rpc.discover registration. README, CHANGELOG and docs/upgrading.md carry the change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of the ten 2.0.0 pull requests sequenced in AUS-1001 (https://linear.app/austins-test/issue/AUS-1001). Ticket: https://linear.app/austins-test/issue/AUS-1003. Stacked on #163; retarget to master once that merges.
SMDServiceCollectionrefuses names beginning withrpc.(ordinal) and the name$/cancelRequestinAdd, the indexer setter andAddBatch(checked under the lock before any entry is copied, so a batch with one reserved name adds nothing). Null names keep theirArgumentNullException.BindMethod, the attribute binder andHandler.RegisterFuctionthroughAddService,BindInterfacethroughAddBatch.BindInterfacedrops its ownrpc.test.AddReservedfor the library's laterrpc.discoverregistration: bypasses only the reserved check, still throws on a duplicate. Unused in 2.0.0.ReservedNameTests(9 tests) cover each path, the accepted look-alikes ($/progress,rpcx,Rpc.x,x.rpc.y,$/cancelrequest,rpc), names compared as given, the batch invariant andAddReserved.Verification on the branch: Release build 0 warnings / 0 errors; 1200 tests pass on net8.0 and net10.0;
check_request_path_sync.py23 listed uses, none unlisted;render.py --checkagrees. Registration is not on the request path, so no benchmark run.