Skip to content

AUS-1002: Remove the obsolete InProcessClient #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astn merged 1 commit into from
Sep 26, 2026
Merged

AUS-1002: Remove the obsolete InProcessClient #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AustinHarris.JsonRpcTestN/Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
}

[Test()]
public void TestInProcessClient()
public void ProcessStringOverloadNullableFloat()
{
string request = @"{""method"":""NullableFloatToNullableFloat"",""params"":[0.0],""id"":1}";
string expectedResult = "{\"jsonrpc\":\"2.0\",\"result\":0.0,\"id\":1}";
Expand All @@ -134,7 +134,7 @@
public void NullableDateTimeToNullableDateTime()
{
string request = @"{""method"":""NullableDateTimeToNullableDateTime"",""params"":[""2014-06-30T14:50:38.5208399+09:00""],""id"":1}";
string expectedResult = "{\"jsonrpc\":\"2.0\",\"result\":\"2014-06-30T14:50:38.5208399+09:00\",\"id\":1}";

Check warning on line 137 in AustinHarris.JsonRpcTestN/Test.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest) 

The variable 'expectedResult' is assigned but its value is never used

Check warning on line 137 in AustinHarris.JsonRpcTestN/Test.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest) 

The variable 'expectedResult' is assigned but its value is never used

Check warning on line 137 in AustinHarris.JsonRpcTestN/Test.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

The variable 'expectedResult' is assigned but its value is never used

Check warning on line 137 in AustinHarris.JsonRpcTestN/Test.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest) 

The variable 'expectedResult' is assigned but its value is never used
var expectedDate = DateTime.Parse("2014-06-30T14:50:38.5208399+09:00");
var result = JsonRpcProcessor.Process(request);
result.Wait();
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ behaviour: a breaking change to either means a new major version.

### Removed

- `InProcessClient` (obsolete since 1.x); call `JsonRpcProcessor.Process` directly.
- The `JsonSerializerSettings` overloads of `JsonRpcProcessor.Process*` (pass a serializer instead; the Newtonsoft package has settings-based helpers).
- Json.NET attributes on `JsonRequest`, `JsonResponse` and `JsonRpcException`.
- The 1.x projects that 2.0 did not build: `AustinHarris.JsonRpc.Client`, `AustinHarris.JsonRpc.AspNet`, the Windows Phone 7 client, `JsonRpcTest` and `TestClient`. They were .NET Framework 4.0 `packages.config` projects outside the solution, referencing packages with open advisories; their source is in the git history before 2.0.
Expand Down
20 changes: 0 additions & 20 deletions Json-Rpc/Client/InProcessJsonRpcClient.cs
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions docs/upgrading.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Most 1.x services run unchanged. Read the first list before you build, and the s

## Changes that break the build

- `InProcessClient` (obsolete since 1.x); call `JsonRpcProcessor.Process` directly.
- **Session parameter.** The session parameter is spelled `sessionId` everywhere; a named argument `sessionID:` must be updated.
- **MethodInfo names.** `RpcMethod.FromMethod` is `FromMethodInfo` and `RpcInterfaceMethod.Method` is `MethodInfo` (both were new in the 2.0 preview).
- **Serializer.** `JsonRpcProcessor.Process(…, JsonSerializerSettings)` is gone from the core. Use `Config.SetSerializer(new NewtonsoftJsonRpcSerializer(settings))` from the Newtonsoft package, or the helper overloads there that take the settings.
Expand Down
Loading