Turn the guidelines into a tested style standard - #2
Open
MarcoDotIO wants to merge 1 commit into
Open
MarcoDotIO wants to merge 1 commit into
MarcoDotIO wants to merge 1 commit into
Conversation
Rebuild the 2017 README into copy-ready style guides and lint configs for the lab's six languages, written for people and for coding agents: - docs: one guide each for C and C++, Python, JavaScript and TypeScript, Swift, Kotlin, and C# and Unity, plus Git and GitHub (the seven commit rules kept), documentation, AI-assisted development, ROS 2 packages, hardware and other languages - configs: .editorconfig, clang-format (ament-compatible) and clang-tidy, swift-format and SwiftLint, ktlint and detekt, C# analyzers, Ruff and mypy, ESLint, Prettier and tsconfig, markdownlint - examples plus scripts/check-configs.sh: every config passes its good samples and rejects its bad ones (28 checks, Docker only), also in CI - README and AGENTS.md templates for lab project repos - AGENTS.md, CLAUDE.md, docs CI and an MIT license (the repo had none) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilds the 2017 guidelines into a tested style standard for the lab's six languages: C and C++; Python; JavaScript and TypeScript; Swift; Kotlin; C# and Unity. Every config is copy-ready and is proven by a check script. Written for people and for coding agents.
What's in it
docs/: one guide per language. Each covers:Plus pages for:
configs/:.editorconfig;ament_clang_formatconfig) and clang-tidy;examples/andscripts/check-configs.sh: each config must pass its good samples and reject itsbad/samples. That is 28 checks, run with only Docker, andconfigs.ymlruns the same checks in CI.templates/: README andAGENTS.mdtemplates for lab project repositories.AGENTS.mdandCLAUDE.md, docs CI, the brand header and social preview.License: MIT. The repository had none, so people can copy the configs freely.
For the reviewer
Style decisions, each explained on its page:
_camelCase, not Unity'sm_prefix.android_studiostyle.type/description.docs/hardware.mdare a proposed lab convention.Also:
ament_cmake_uncrustifyand useament_cmake_clang_format. Testing showed the two can't both pass.AGENTS.md:How it was checked
scripts/check-configs.sh: 28 of 28 pass, and each linter rejects its bad samples. It was run twice, once by me on a separate run.colcon buildandcolcon testpass 30 tests, including cpplint, cppcheck, flake8 and pep257.brand_check.py: 0 errors. markdownlint: 0 issues. lychee: 0 errors. actionlint and shellcheck are clean..editorconfigseverities. The docs say how to check the latter.After merge
developbranch is fully merged intomasterand can be deleted..github/assets/social-preview.pngunder Settings → Social preview.Related PRs: .github · about · getting-started-atr-lab · all-things-ros2
🤖 Generated with Claude Code