Skip to content

refactor(web): extract shared UI and host packages - #842

Open
mnoah1 wants to merge 1 commit into
mainfrom
mnoah1/web-shared-foundation
Open

mnoah1 wants to merge 1 commit into
mainfrom
mnoah1/web-shared-foundation

Conversation

@mnoah1

@mnoah1 mnoah1 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Why?

Much of the structure around the new SubmitQueue UI is reusable for a Stovepipe UI as well. This PR pulls out common components into shared packages that can be used across both services to minimize duplication.

What?

  • Move shared React navigation, polling, timestamp formatting, path-segment helpers, and styles into web/platform (@submitqueue/web-platform).
  • Move common Basic auth, Node gRPC transport, Next.js navigation, and readiness checks into web/service/shared (@submitqueue/web-service-shared). Service-specific configuration stays in the host.
  • Update SubmitQueue to import the shared implementations directly, preserving its public exports and existing behavior.
  • Share the Bazel library build, packaging, and lint setup, and update workspace and package-consumer checks.

Test Plan

Shared-package checks and the existing SubmitQueue browser suite passed; the latest rebased stack passed all 32 targets with ./tool/bazel test //web:check //web/test/e2e/submitqueue:web_test //web/test/e2e/stovepipe:web_test --test_output=errors. To validate this PR independently:

./tool/bazel test //web:check //web/test/e2e:web_test --test_output=errors

Repository formatting, lint, module tidy, and Gazelle checks also passed.

Revert Plan

Revert dependent PRs #844, #838, and #837 first if merged, then revert this PR to restore the original SubmitQueue package layout.

Stack

  1. refactor(web): extract shared UI and host packages #842 — shared-package refactoring
  2. feat(web): add Stovepipe request status UI #837 — Stovepipe frontend
  3. test(web): add Stovepipe coverage and align E2E suites #838 — browser coverage and E2E organization
  4. refactor(web): let hosts handle request logging #844 — host logging integration

@mnoah1
mnoah1 force-pushed the mnoah1/web-shared-foundation branch from 953f414 to de5ea40 Compare October 12, 2026 15:13
@mnoah1
mnoah1 added this pull request to stack #843 October 12, 2026 15:29
@mnoah1
mnoah1 marked this pull request as ready for review October 12, 2026 15:31
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners October 12, 2026 15:31
@mnoah1
mnoah1 removed this pull request from stack #843 October 12, 2026 20:08
@mnoah1
mnoah1 added this pull request to stack #847 October 12, 2026 20:08
@mnoah1
mnoah1 force-pushed the mnoah1/web-shared-foundation branch 2 times, most recently from 6e66329 to 6e42848 Compare October 13, 2026 17:24
@mnoah1
mnoah1 force-pushed the mnoah1/web-shared-foundation branch from 6e42848 to ba3f6c9 Compare October 13, 2026 19:31

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant