Skip to content

test(web): add Stovepipe coverage and align E2E suites - #838

Open
mnoah1 wants to merge 1 commit into
mnoah1/stovepipe-webfrom
mnoah1/stovepipe-web-e2e
Open

mnoah1 wants to merge 1 commit into
mnoah1/stovepipe-webfrom
mnoah1/stovepipe-web-e2e

Conversation

@mnoah1

@mnoah1 mnoah1 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Why?

The new Stovepipe UI needs browser coverage against a real backend, in addition to its unit and component tests. Align both services' browser suites under web/test/e2e/<domain> so they follow the repository layout and reuse stack setup helpers.

What?

  • Move the existing SubmitQueue browser suite into web/test/e2e/submitqueue, preserving its browser spec and Compose overlay.
  • Add web/test/e2e/stovepipe with real ingestion and seeded pagination data. Cover queue navigation and cursors, request-ID links and reloads, backend status summaries above history, refresh, empty queues, and accessibility. A summary with a newer state than the history verifies that the UI does not reconstruct status from events.
  • Share image loading, schema application, and port lookup helpers. Both browser runners use the Bazel-pinned Compose executable from chore(docker): supply docker compose via Bazel #830.
  • Update Bazel targets and visibility, workspace entries, runner commands, and test documentation for the new layout. Tests emit queue and request-page screenshots as Bazel test outputs.

Test Plan

Latest validation passed all 32 targets, including both services' real-stack browser suites:

./tool/bazel test //web:check //web/test/e2e/submitqueue:web_test //web/test/e2e/stovepipe:web_test --test_output=errors

Repository formatting, lint, module tidy, and Gazelle checks also passed. Browser tests require a running Docker daemon; Bazel supplies Compose and the browser.

Stack

  1. refactor(web): extract shared UI and host packages #842 — shared-package refactoring
  2. feat(web): add Stovepipe request status UI #837 — Stovepipe frontend
  3. test(web): add Stovepipe coverage and align E2E suites #838 — browser coverage and E2E organization
  4. refactor(web): let hosts handle request logging #844 — host logging integration

@mnoah1
mnoah1 added this pull request to stack #839 October 12, 2026 14:22
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-web-e2e branch from 95f5825 to 99bb189 Compare October 12, 2026 14:51
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-web-e2e branch from 99bb189 to 2df95bd Compare October 12, 2026 15:00
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-web-e2e branch from 2df95bd to 9e37974 Compare October 12, 2026 15:13
@mnoah1
mnoah1 removed this pull request from stack #839 October 12, 2026 15:29
@mnoah1
mnoah1 added this pull request to stack #843 October 12, 2026 15:29
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-web-e2e branch from 9e37974 to 96605a6 Compare October 12, 2026 15:44
@mnoah1
mnoah1 marked this pull request as ready for review October 12, 2026 15:50
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners October 12, 2026 15:50
mnoah1 added a commit that referenced this pull request Oct 12, 2026
Send web logs through per-request callbacks so hosts can use their own logging context. Keep Pino in the reference hosts, preserve original errors and structured fields, and isolate callback failures from page results.

Builds on the web E2E layer in #838.
@mnoah1
mnoah1 removed this pull request from stack #843 October 12, 2026 20:08
@mnoah1
mnoah1 added this pull request to stack #847 October 12, 2026 20:08
@mnoah1 mnoah1 changed the title test(web): add Stovepipe coverage and align E2E suites [DRAFT/WIP] test(web): add Stovepipe coverage and align E2E suites Oct 12, 2026
@mnoah1
mnoah1 marked this pull request as draft October 12, 2026 22:05
mnoah1 added a commit that referenced this pull request Oct 13, 2026
Send web logs through per-request callbacks so hosts can use their own logging context. Keep Pino in the reference hosts, preserve original errors and structured fields, and isolate callback failures from page results.

Builds on the web E2E layer in #838.
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-web-e2e branch from 96605a6 to 7f394f9 Compare October 13, 2026 13:41
mnoah1 added a commit that referenced this pull request Oct 13, 2026
Send web logs through per-request callbacks so hosts can use their own logging context. Keep Pino in the reference hosts, preserve original errors and structured fields, and isolate callback failures from page results.

Builds on the web E2E layer in #838.
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-web-e2e branch from 7f394f9 to c1ce012 Compare October 13, 2026 17:10
mnoah1 added a commit that referenced this pull request Oct 13, 2026
Send web logs through per-request callbacks so hosts can use their own logging context. Keep Pino in the reference hosts, preserve original errors and structured fields, and isolate callback failures from page results.

Builds on the web E2E layer in #838.
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-web-e2e branch from c1ce012 to 0469e2e Compare October 13, 2026 17:24
@mnoah1 mnoah1 changed the title [DRAFT/WIP] test(web): add Stovepipe coverage and align E2E suites test(web): add Stovepipe coverage and align E2E suites Oct 13, 2026
@mnoah1
mnoah1 marked this pull request as ready for review October 13, 2026 17:38
mnoah1 added a commit that referenced this pull request Oct 13, 2026
Send web logs through per-request callbacks so hosts can use their own logging context. Keep Pino in the reference hosts, preserve original errors and structured fields, and isolate callback failures from page results.

Builds on the web E2E layer in #838.
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-web-e2e branch from 0469e2e to 9786a7b Compare October 13, 2026 19:31

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant