Skip to content

run seed on merge to upsert - #49

Merged
Marfuen merged 1 commit into
mainfrom
mariano/stuff
Feb 12, 2025
Merged

Marfuen merged 1 commit into
mainfrom
mariano/stuff

Conversation

@Marfuen

@Marfuen Marfuen commented Feb 12, 2025 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Introduced an automated process to seed essential data during database migrations to ensure systems are consistently initialized.
  • Chores
    • Updated the seeding process to preserve existing data, streamlining updates and maintaining current records.

@vercel

vercel Bot commented Feb 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 7:31pm
web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 7:31pm

@Marfuen
Marfuen merged commit 6ede476 into main Feb 12, 2025
@coderabbitai

coderabbitai Bot commented Feb 12, 2025 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a new step in the GitHub Actions workflow for database migrations to seed the database using bunx prisma db seed. Additionally, it removes the cleanup code from the seed script, so the seeding process now runs without deleting existing data. Both changes adjust the control flow within their respective contexts: the workflow now performs an additional seeding step, and the seed script skips the previously executed data cleanup steps.

Changes

File(s) Summary of Changes
.github/.../database-migrations.yml Added a new step, Run database seed, in the migrate job after Generate Prisma Client. This step executes bunx prisma db seed using the repository’s DATABASE_URL.
packages/.../prisma/seed.ts Removed a block of cleanup code that deleted existing data and corresponding log statements. The seeding process now continues directly with seeding policies, frameworks, and policy frameworks.

Sequence Diagram(s)

sequenceDiagram
    participant CI as GitHub Actions
    participant Runner as Workflow Runner
    participant DB as Database

    CI->>Runner: Trigger migrate job
    Runner->>Runner: Generate Prisma Client
    Runner->>Runner: Run database seed (new step)
    Runner->>DB: Execute `bunx prisma db seed`
    DB-->>Runner: Return seed results
Loading
sequenceDiagram
    participant Script as Seed Script
    participant DB as Database

    Note over Script: Directly seed data without cleanup
    Script->>DB: Seed policies
    Script->>DB: Seed frameworks
    Script->>DB: Seed policy frameworks
    DB-->>Script: Confirm data insertion
Loading

Poem

Oh, what a hop in our code today,
A new step to seed without delay!
Cleaning is gone, the seeds now flow,
In our workflow, watch them grow.
With a twitch of my nose and a happy leap,
I celebrate changes, both exciting and deep!
🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79e81f1 and 90de636.

📒 Files selected for processing (2)
  • .github/workflows/database-migrations.yml (1 hunks)
  • packages/db/prisma/seed.ts (0 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

tofikwest pushed a commit that referenced this pull request Sep 23, 2026
…H-49, GH-52, GH-75, GH-102, GH-272) (#3573)

* fix(api): derive soa organizationId from session, not request body

Every SOA handler now overwrites dto.organizationId with the trusted
@organizationId() session value before calling the service, closing the
cross-tenant read/tamper/destroy gap in save-answer, auto-fill,
create-document, ensure-setup, approve, decline, and submit-for-approval.

Refs GH-36

* fix(api): scope task automations to task and organization

automationId lookups are now verified against the task in the URL and
the caller's organization via a shared verifyAutomationAccess helper, so
an automationId from another org's task 404s on read, update, delete,
runs, versions, and publish instead of leaking or mutating it.

Refs GH-46

* fix(api): harden public trust-portal access endpoints

reclaimAccess no longer returns the access link/token in the response
body and returns an identical generic message whether or not a grant
exists, removing the unauthenticated token disclosure and the
email-enumeration oracle; the link is only emailed to the requester.

findPublishedTrustByRouteId no longer auto-creates a published Trust row
or flips drafts to published: public endpoints only resolve rows that
are already published and 404 otherwise, so an unauthenticated caller
can no longer force-publish an organization's trust portal.

Refs GH-42, GH-272

* fix(app): require session and org match in task-automation actions

Every exported server action now resolves the caller's session and
active organization and fails closed when unauthenticated. Actions that
take orgId must match the session's active org; S3 keys must be prefixed
with the active org; automationId-only actions verify ownership through
the automation's task before proxying to the enterprise API.

Refs GH-52

* fix(app): require auth and run ownership before minting trigger tokens

healAndSetAccessToken and createAccessToken now require a session with
an active organization and only mint a Trigger.dev run-read token when
the run id is recorded against that organization (onboarding job,
knowledge base document, or remediation batch).

Refs GH-102

* ci(device-agent): restrict release workflow to protected branches

The device-agent release pipeline runs branch-controlled build scripts
with Apple and SSL.com code-signing secrets in scope, so push triggers
are now limited to main and release (manual staging builds remain via
workflow_dispatch), and the secret-bearing jobs are gated behind the
staging/production GitHub environments.

Refs GH-49, GH-75

This branch was successfully deployed

2 active deployments
Preview – app — 90de6363 Deployed Feb 12, 2025 by vercel[bot]
Preview – web — 90de6363 Deployed Feb 12, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant