Skip to content

no toast or invite to portal - #272

Merged
Marfuen merged 2 commits into
mainfrom
mariano/risk-improvements
Apr 3, 2025
Merged

Marfuen merged 2 commits into
mainfrom
mariano/risk-improvements

Conversation

@Marfuen

@Marfuen Marfuen commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Apr 3, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
app ⬜️ Skipped (Inspect) Apr 3, 2025 11:32pm
comp-portal ⬜️ Skipped (Inspect) Apr 3, 2025 11:32pm

@coderabbitai

coderabbitai Bot commented Apr 3, 2025 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@Marfuen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 3e8ea44 and bb5c2cc.

📒 Files selected for processing (2)
  • apps/app/src/components/sheets/add-employee-sheet.tsx (1 hunks)
  • apps/app/src/lib/db/employee.ts (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
vercel Bot temporarily deployed to Preview – comp-portal April 3, 2025 23:32 Inactive
@vercel
vercel Bot temporarily deployed to Preview – app April 3, 2025 23:32 Inactive
@Marfuen
Marfuen merged commit 29d1ccc into main Apr 3, 2025
tofikwest pushed a commit that referenced this pull request Sep 23, 2026
…H-49, GH-52, GH-75, GH-102, GH-272) (#3573)

* fix(api): derive soa organizationId from session, not request body

Every SOA handler now overwrites dto.organizationId with the trusted
@organizationId() session value before calling the service, closing the
cross-tenant read/tamper/destroy gap in save-answer, auto-fill,
create-document, ensure-setup, approve, decline, and submit-for-approval.

Refs GH-36

* fix(api): scope task automations to task and organization

automationId lookups are now verified against the task in the URL and
the caller's organization via a shared verifyAutomationAccess helper, so
an automationId from another org's task 404s on read, update, delete,
runs, versions, and publish instead of leaking or mutating it.

Refs GH-46

* fix(api): harden public trust-portal access endpoints

reclaimAccess no longer returns the access link/token in the response
body and returns an identical generic message whether or not a grant
exists, removing the unauthenticated token disclosure and the
email-enumeration oracle; the link is only emailed to the requester.

findPublishedTrustByRouteId no longer auto-creates a published Trust row
or flips drafts to published: public endpoints only resolve rows that
are already published and 404 otherwise, so an unauthenticated caller
can no longer force-publish an organization's trust portal.

Refs GH-42, GH-272

* fix(app): require session and org match in task-automation actions

Every exported server action now resolves the caller's session and
active organization and fails closed when unauthenticated. Actions that
take orgId must match the session's active org; S3 keys must be prefixed
with the active org; automationId-only actions verify ownership through
the automation's task before proxying to the enterprise API.

Refs GH-52

* fix(app): require auth and run ownership before minting trigger tokens

healAndSetAccessToken and createAccessToken now require a session with
an active organization and only mint a Trigger.dev run-read token when
the run id is recorded against that organization (onboarding job,
knowledge base document, or remediation batch).

Refs GH-102

* ci(device-agent): restrict release workflow to protected branches

The device-agent release pipeline runs branch-controlled build scripts
with Apple and SSL.com code-signing secrets in scope, so push triggers
are now limited to main and release (manual staging builds remain via
workflow_dispatch), and the secret-bearing jobs are gated behind the
staging/production GitHub environments.

Refs GH-49, GH-75

This branch was previously deployed

2 inactive deployments
Preview – comp-portal — bb5c2cce Deployed Apr 3, 2025 by vercel[bot]
Preview – app — bb5c2cce Deployed Apr 3, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant