Reject zero per-repo concurrency - #87
Open
behinddwalls wants to merge 1 commit into
Open
behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
This was referenced Sep 30, 2026
behinddwalls
marked this pull request as ready for review
September 30, 2026 20:02
A zero-sized per-repository semaphore can never grant a permit, so a valid-looking configuration caused every Git request for a repository to wait indefinitely. Require `server.max_concurrent_per_repo` to be positive and add a regression test for the invalid zero value. ✅ `cargo test -p walgit-config zero_per_repo_concurrency_is_rejected` ✅ `cargo fmt --all -- --check` ✅ `git diff --check` Closes tobi#79
behinddwalls
force-pushed
the
preetam/issue-79-per-repo-concurrency
branch
from
October 1, 2026 18:11
74daa5d to
77ade75
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
A zero-sized per-repository semaphore can never grant a permit, so a valid-looking configuration caused every Git request for a repository to wait indefinitely.
What?
Require
server.max_concurrent_per_repoto be positive and add a regression test for the invalid zero value.Test Plan
✅
cargo test -p walgit-config zero_per_repo_concurrency_is_rejected✅
cargo fmt --all -- --check✅
git diff --checkIssue
Closes #79